Add selectionLimit option to SelectionAdapter#595
Draft
oltionchampari wants to merge 3 commits intodevelopfrom
Draft
Add selectionLimit option to SelectionAdapter#595oltionchampari wants to merge 3 commits intodevelopfrom
oltionchampari wants to merge 3 commits intodevelopfrom
Conversation
oltionchampari
changed the title
thinkh
approved these changes
Dec 17, 2021
Member
There was a problem hiding this comment.
Looks good to me.
@puehringer could you also please have a look if the changes work for you?
Does it make sense to add the selection limit feature to the ARankingView and make generally available?
Member
|
@oltionchampari I agreed with @puehringer before the holidays that we should implement this feature as part of the |
Contributor
Author
|
Waiting for #615 to be completed to update this PR |
Contributor
|
@oltionchampari @thinkh Is this still relevant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
see Caleydo/tdp_bi_bioinfodb#1316