Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New-DbaEndpoint - New parameter AuthenticationOrder #9145

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

andreasjordan
Copy link
Contributor

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes New-DbaEndpoint - Allow Setting Payload.DatabaseMirroring.EndpointAuthenticationOrder #8759 )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

See issue for details.

Setting an SPN to be able to use Kerberos is out of the scope of the command, as it needs permissions in the active directory. We have Set-DbaSpn for that purpose.

@mattcargile Can you please test this branch?

@potatoqualitee potatoqualitee merged commit ed4c3ec into development Nov 5, 2023
11 checks passed
@potatoqualitee potatoqualitee deleted the NewDbaEndpoint_AuthenticationOrder branch November 5, 2023 09:53
@potatoqualitee
Copy link
Member

Excellent addition, thank you 🙏🏼 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New-DbaEndpoint - Allow Setting Payload.DatabaseMirroring.EndpointAuthenticationOrder
2 participants