Skip to content

Updating singer_stream.py to allow schemas without properties #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucas wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Updating singer_stream.py to allow schemas without properties #220

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd61bf1
Updating singer_stream.py to allow schemas without properties
lucas Aug 28, 2022
4400e6a
Setting schema properties check to return empty dictionary if key doe…
lucas Sep 1, 2022
9bf7d2a
Whitespace cleanup
lucas Sep 1, 2022
2b569b7
Update setup.py
lucas Nov 19, 2022
e4ddb92
Update singer_stream.py
lucas Nov 19, 2022
b1f948f
Update singer_stream.py
lucas Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion target_postgres/singer_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,11 @@ def update_schema(self, schema, key_properties):

# The validator can handle _many_ more things than our simplified schema, and is, in general handled by third party code
self.validator = Draft4Validator(schema, format_checker=FormatChecker())


# Some taps do not provide 'properties' key, which causes the next block to fail
if not (self.schema and 'properties' in self.schema):
return

properties = self.schema['properties']

if singer.RECEIVED_AT not in properties:
Expand Down