Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch46955] Dedicated Amazon Comprehend Medical plugin #1

Merged
merged 27 commits into from
Jun 3, 2020

Conversation

alexcombessie
Copy link
Contributor

@alexcombessie alexcombessie commented May 7, 2020

Link to clubhouse story ch46955

@alexcombessie alexcombessie marked this pull request as draft May 7, 2020 17:04
@alexcombessie alexcombessie self-assigned this May 7, 2020
@alexcombessie alexcombessie marked this pull request as ready for review May 7, 2020 18:41
@alexcombessie alexcombessie changed the title Dedicated Amazon Comprehend Medical plugin [ch46955] Dedicated Amazon Comprehend Medical plugin May 7, 2020
@alexcombessie
Copy link
Contributor Author

Hi @MayeulRousselet! Will you have some time to look at this PR this week? It's exactly similar to the Amazon Comprehend (no medical) one which has been merged. Thanks!

@alexcombessie alexcombessie requested review from MayeulRousselet and removed request for MayeulRousselet May 25, 2020 08:56
@alexcombessie
Copy link
Contributor Author

👋 @MayeulRousselet

@alexcombessie
Copy link
Contributor Author

TODO add logging if entities are filtered by the minimum_score parameter

Copy link
Collaborator

@MayeulRousselet MayeulRousselet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, good work

@alexcombessie alexcombessie merged commit 9765c4d into master Jun 3, 2020
@alexcombessie alexcombessie deleted the feature/1.0 branch June 3, 2020 18:57
@alexcombessie alexcombessie added this to the 1.0.0 milestone Jul 23, 2020
@alexcombessie alexcombessie added enhancement New feature or request and removed pr-changes-done labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants