This repository was archived by the owner on Jun 11, 2024. It is now read-only.
Feature/grant_CREATE_to_collaborator #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacyho
changed the title
stacyho
changed the title
RogerTangos
reviewed
Feb 21, 2017
| params = tuple(map(lambda x: AsIs(x), params)) | ||
| res = self.execute_sql(query, params) | ||
|
|
||
| query = ('BEGIN;' |
There was a problem hiding this comment.
It appears that this grants CREATE to all users when added as collaborators. There's no check grantCreatePrivilege's value.
There was a problem hiding this comment.
This also has one too many spaces, though that's more of a silly codeclimate issue.
https://codeclimate.com/github/datahuborg/datahub/pull/204
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on Issue #157