Add HeadersProvider which provides needed gRPC connection headers
#5
+555
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: teodordelibasic-db <[email protected]>
teodordelibasic-db
force-pushed
the
headers-provider
branch
from
9bbfb3b to
4a38b87
Compare
Signed-off-by: teodordelibasic-db <[email protected]>
Signed-off-by: teodordelibasic-db <[email protected]>
| ) -> ZerobusStream | ||
| ``` | ||
| Creates a new ingestion stream. Returns a `ZerobusStream` instance. | ||
| Creates a new ingestion stream using OAuth 2.0 Client Credentials authentication. |
There was a problem hiding this comment.
Maybe we should mention that you also have to align with existing methods of authentication. Because I can already see a situation where someone will override this and not include needed authentication headers for Zerobus and complain.
Comment on lines
18
to
+21
| ### API Changes | ||
|
|
||
| - Added `HeadersProvider` abstract base class for custom header strategies | ||
| - Added `OAuthHeadersProvider` class for OAuth 2.0 authentication with Databricks OIDC endpoint |
There was a problem hiding this comment.
We should add the create_stream_with_headers_provider method here too
Signed-off-by: teodordelibasic-db <[email protected]>
elenagaljak-db
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
HeadersProviderclass which has an abstract method to return touples of header keys and values for gRPC metadata.OAuthHeadersProviderclass which is implicitly created increate_streammethod so that we don't break the existing API.How is this tested?