Telemetry server-side flag integration #646
Open
+206
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sai Shree Pradhan <[email protected]>
saishreeeee
requested review from
samikshya-db
and removed request for
samikshya-db
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
| from typing import Dict, Optional, List, Any, TYPE_CHECKING | ||
|
|
||
| if TYPE_CHECKING: | ||
| from databricks.sql.client import Connection |
There was a problem hiding this comment.
It is for static type checking and prevents circular imports
| # We don't check for an in-flight refresh; the executor queues the task, which is safe. | ||
| self._executor.submit(self._refresh_flags) | ||
|
|
||
| assert self._flags is not None |
There was a problem hiding this comment.
does this mean we will just fail if we aren't able to fetch flags? shouldn't we do safe defaults?
There was a problem hiding this comment.
If there is an exception in _refresh_flags(), _flags is set to an empty Dict. If the particular flag we are checking is set to None, we use the default value passed in the args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents
PECOBLR-583