-
Notifications
You must be signed in to change notification settings - Fork 114
SEA: Cleanup #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
varun-edachali-dbx
wants to merge
10
commits into
sea-migration
Choose a base branch
from
sea-cleanup
base: sea-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SEA: Cleanup #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
5 tasks
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Signed-off-by: varun-edachali-dbx <[email protected]>
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
ResultSet
, infer fromConnection
insteadSession
constructor into a type / namedtupleConnectionParams
session
closed
flag in the beginning ofsession
close()
(currently set at the end)decision
: the sessionclosed
flag should be set at the end of the session'sclose
method. The flag should only be set if the session has successfully closed. Setting the flag at the beginning would lead to a resource leak because if the session closure fails and the user attempts to clean up resources by attempting toclose()
again, our code would disallow another request being made because we already consider the session to be closed.pros
: logical coherence - the session is only marked as closed if it successfully gets closed + maintenance of existing behaviourcons
: the session may not actually get closed despite the user attempting aclose()
.ExecuteResponse
sea/
andbackend/
relationHow is this tested?
Related Tickets & Documents
PECOBLR-531
PECOBLR-447
PECOBLR-448
PECOBLR-603
PECOBLR-606