Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Decouple serving and oauth2 package #1110

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

parthban-db
Copy link
Contributor

@parthban-db parthban-db commented Jan 3, 2025

What changes are proposed in this pull request?

Package oauth2 contains a DataPlaneService that is not intended for users to use directly. This service is not auto-generated and is only used in the serving package. To remove the dependency between the serving package and the oauth2 package, this PR moves the DataPlaneService from the oauth2 to the serving package.

Note: serving package still depends on the oauth2 package for DataPlaneInfo struct. This dependency cannot be removed right now as it is in the OpenAPI.

How is this tested?

Existing unit tests

Copy link

github-actions bot commented Jan 3, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1110
  • Commit SHA: 4399da5c6a0baed196b4c6ff8f285a1883d7aa96

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants