Remove clippy warnings #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nleroy917
requested review from
donaldcampbelljr and
khoroshevskyi
and removed request for
donaldcampbelljr
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #109 +/- ##
==========================================
+ Coverage 61.97% 63.74% +1.76%
==========================================
Files 38 36 -2
Lines 6478 5786 -692
==========================================
- Hits 4015 3688 -327
+ Misses 2463 2098 -365 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
donaldcampbelljr
approved these changes
Mar 20, 2025
Comment on lines
135
to
+136
| let region = self.universe.borrow(py).convert_id_to_region(id); | ||
| match region { | ||
| Some(r) => Some(r.into()), | ||
| None => None, | ||
| } | ||
| region |
There was a problem hiding this comment.
Ok, for items like this, are we certain region will be None without the match statement?
There was a problem hiding this comment.
So I think that the reason Clippy sked for this is that the match is redundant... if it matches Some, we immediately turn into Some again... If it matches None we immediately return None. I think that's why it had me change this.
|
Thanks for doing this. |
khoroshevskyi
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #105 .
I use
clippyto improve my rust code, catch small things, etc. The current code base had >180 warnings that made it difficult for me to see true errors through the sea of warnings...I want in and remove them by either 1) implementing the fix, or 2) manually suppressing the warning. Overwhelmingly, the warnings were small things like:
or
There were some more elusive warnings about us passing references that get auto-dereferenced by the compiler.
All tests still pass.