Skip to content

feat(meta): add VoteV001 RPC with native protobuf types #18396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 20, 2025

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jul 20, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(meta): add VoteV001 RPC with native protobuf types
  • Add VoteRequest and VoteResponse protobuf messages to raft.proto
  • Implement VoteV001 RPC endpoint alongside existing Vote RPC
  • Add conversion traits between protobuf and internal types
  • Implement backward compatibility with fallback to legacy Vote RPC
  • Update version compatibility matrix for new RPC method

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Other

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jul 20, 2025
- Add VoteRequest and VoteResponse protobuf messages to raft.proto
- Implement VoteV001 RPC endpoint alongside existing Vote RPC
- Add conversion traits between protobuf and internal types
- Implement backward compatibility with fallback to legacy Vote RPC
- Update version compatibility matrix for new RPC method
@drmingdrmer drmingdrmer marked this pull request as ready for review July 20, 2025 13:49
@drmingdrmer drmingdrmer merged commit a8105f5 into databendlabs:main Jul 20, 2025
89 checks passed
@drmingdrmer drmingdrmer deleted the 359-vote-v001 branch July 20, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant