Skip to content

fix(rtl): physical → logical Tailwind props (9 files)#26

Open
abdout wants to merge 1 commit into
mainfrom
fix/rtl-logical-properties
Open

fix(rtl): physical → logical Tailwind props (9 files)#26
abdout wants to merge 1 commit into
mainfrom
fix/rtl-logical-properties

Conversation

@abdout
Copy link
Copy Markdown
Contributor

@abdout abdout commented Apr 25, 2026

Summary

  • Audit found 67 unconditional physical Tailwind props across 22 files. This PR sweeps the 9 live, non-shadcn, unconditional ones.
  • Mechanical mapping: `ml-`→`ms-`, `mr-`→`me-`, `pl-`→`ps-`, `pr-`→`pe-`, `text-left`→`text-start`, `text-right`→`text-end`. Logical props auto-flip under `dir="rtl"` so Arabic users get correct spacing.

Changes

File Conversions
`wizard/cutomizer.tsx` `pr-2`, `ml-auto`, `mr-1` ×3
`wizard/theme.tsx` `mr-2` ×2
`template/wizard-footer.tsx` `mr-2` ×2, `ml-2`
`marketing/ready-to-build.tsx` `pr-5`
`marketing/pricing/forms/billing-form-button.tsx` `mr-2`
`marketing/pricing/shared/toc.tsx` `pl-4`
`marketing/pricing/mobile-compare-plans.tsx` `pr-2`, `text-left`
`marketing/pricing/pricing-faqs.tsx` `lg:text-left`
`marketing/service/layout-card.tsx` `md:text-left` ×2

Test plan

  • /ar/wizard — Theme Customizer panel mirrors correctly
  • /ar — ready-to-build, pricing FAQs, compare-plans visual check at desktop + mobile
  • /en — visually unchanged
  • `pnpm tsc --noEmit` no new errors

Skipped (deferred)

  • shadcn primitives in `src/components/ui/*` — managed via shadcn CLI; ideally updated by `shadcn add` sync
  • `isRTL ? 'pl-4' : 'pr-4'` ternary simplifications — these already RTL-aware, just verbose
  • Dead/clone-artifact files in `pricing/sections/*`
  • ESLint rule to prevent new physical props

Closes #25

🤖 Generated with Claude Code

Conservative first sweep. Replaces unconditional ml-/mr-/pl-/pr-/
text-left/text-right with ms-/me-/ps-/pe-/text-start/text-end so they
auto-flip under dir="rtl". Skipped shadcn ui/* (managed via CLI),
isRTL ternaries (already RTL-aware), and dead clone artifacts.

Closes #25

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marketing Ready Ready Preview, Comment Apr 25, 2026 0:28am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(rtl): replace physical Tailwind props with logical equivalents

1 participant