Skip to content

feat(i18n): expert-modal SelectItems + billing-toggle aria-labels #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdout wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(i18n): expert-modal SelectItems + billing-toggle aria-labels #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/components/internationalization/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,27 @@
"benefit1": "احصل على توصيات الخبراء خلال 24 ساعة",
"benefit2": "خارطة طريق مخصصة للمشروع والجدول الزمني",
"benefit3": "الوصول المباشر إلى استشاريينا الكبار",
"submit": "احصل على مساعدة الخبراء"
"submit": "احصل على مساعدة الخبراء",
"projectTypes": {
"website": "تطوير موقع إلكتروني",
"ecommerce": "منصة تجارة إلكترونية",
"mobile": "تطبيق جوال",
"custom": "برنامج مخصص",
"consulting": "استشارات تقنية"
},
"budgets": {
"lt1000": "أقل من 1,000$",
"1000to5000": "1,000$ - 5,000$",
"5000to10000": "5,000$ - 10,000$",
"gt10000": "10,000$ فأكثر"
},
"timelines": {
"asap": "في أقرب وقت",
"oneMonth": "خلال شهر",
"oneToThreeMonths": "1-3 أشهر",
"threeToSixMonths": "3-6 أشهر"
},
"toggleMonthlyAria": "تبديل الفوترة الشهرية",
"toggleYearlyAria": "تبديل الفوترة السنوية"
}
}
23 changes: 22 additions & 1 deletion src/components/internationalization/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,27 @@
"benefit1": "Get expert recommendations within 24 hours",
"benefit2": "Personalized project roadmap and timeline",
"benefit3": "Direct access to our senior consultants",
"submit": "Get Expert Help"
"submit": "Get Expert Help",
"projectTypes": {
"website": "Website Development",
"ecommerce": "E-commerce Platform",
"mobile": "Mobile Application",
"custom": "Custom Software",
"consulting": "Technical Consulting"
},
"budgets": {
"lt1000": "Less than $1,000",
"1000to5000": "$1,000 - $5,000",
"5000to10000": "$5,000 - $10,000",
"gt10000": "$10,000+"
},
"timelines": {
"asap": "ASAP",
"oneMonth": "Within 1 month",
"oneToThreeMonths": "1-3 months",
"threeToSixMonths": "3-6 months"
},
"toggleMonthlyAria": "Toggle monthly billing",
"toggleYearlyAria": "Toggle yearly billing"
}
}
26 changes: 13 additions & 13 deletions src/components/marketing/expert-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,11 @@ export function ExpertModal({ isOpen, onClose }: ExpertModalProps) {
<SelectValue placeholder={t.expert?.projectTypePlaceholder || 'Select project type'} />
</SelectTrigger>
<SelectContent>
<SelectItem value="website">Website Development</SelectItem>
<SelectItem value="ecommerce">E-commerce Platform</SelectItem>
<SelectItem value="mobile">Mobile Application</SelectItem>
<SelectItem value="custom">Custom Software</SelectItem>
<SelectItem value="consulting">Technical Consulting</SelectItem>
<SelectItem value="website">{t.expert.projectTypes.website}</SelectItem>
<SelectItem value="ecommerce">{t.expert.projectTypes.ecommerce}</SelectItem>
<SelectItem value="mobile">{t.expert.projectTypes.mobile}</SelectItem>
<SelectItem value="custom">{t.expert.projectTypes.custom}</SelectItem>
<SelectItem value="consulting">{t.expert.projectTypes.consulting}</SelectItem>
</SelectContent>
</Select>
{errors.projectType && (
Expand All @@ -179,10 +179,10 @@ export function ExpertModal({ isOpen, onClose }: ExpertModalProps) {
<SelectValue placeholder={t.expert?.budgetPlaceholder || 'Budget'} />
</SelectTrigger>
<SelectContent>
<SelectItem value="<1000">Less than $1,000</SelectItem>
<SelectItem value="1000-5000">$1,000 - $5,000</SelectItem>
<SelectItem value="5000-10000">$5,000 - $10,000</SelectItem>
<SelectItem value="10000+">$10,000+</SelectItem>
<SelectItem value="<1000">{t.expert.budgets.lt1000}</SelectItem>
<SelectItem value="1000-5000">{t.expert.budgets["1000to5000"]}</SelectItem>
<SelectItem value="5000-10000">{t.expert.budgets["5000to10000"]}</SelectItem>
<SelectItem value="10000+">{t.expert.budgets.gt10000}</SelectItem>
</SelectContent>
</Select>

Expand All @@ -194,10 +194,10 @@ export function ExpertModal({ isOpen, onClose }: ExpertModalProps) {
<SelectValue placeholder={t.expert?.timelinePlaceholder || 'Timeline'} />
</SelectTrigger>
<SelectContent>
<SelectItem value="asap">ASAP</SelectItem>
<SelectItem value="1month">Within 1 month</SelectItem>
<SelectItem value="3months">1-3 months</SelectItem>
<SelectItem value="6months">3-6 months</SelectItem>
<SelectItem value="asap">{t.expert.timelines.asap}</SelectItem>
<SelectItem value="1month">{t.expert.timelines.oneMonth}</SelectItem>
<SelectItem value="3months">{t.expert.timelines.oneToThreeMonths}</SelectItem>
<SelectItem value="6months">{t.expert.timelines.threeToSixMonths}</SelectItem>
</SelectContent>
</Select>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/marketing/pricing/billing-toggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ export function BillingToggle({ isYearly, onChange }: BillingToggleProps) {
"min-w-[80px] px-3 md:min-w-[148px] md:px-6",
isYearly ? "text-muted-foreground hover:text-foreground" : "text-foreground",
)}
aria-label="Toggle monthly billing"
aria-label={t.expert.toggleMonthlyAria}
>
{t.marketing.pricing.constants.monthly.toUpperCase()}
</ToggleGroupItem>
);

const yearlyButton = (
<ToggleGroupItem
value="yearly"
Expand All @@ -35,7 +35,7 @@ export function BillingToggle({ isYearly, onChange }: BillingToggleProps) {
"min-w-[80px] px-3 md:min-w-[148px] md:px-6",
isYearly ? "text-foreground" : "text-muted-foreground hover:text-foreground",
)}
aria-label="Toggle yearly billing"
aria-label={t.expert.toggleYearlyAria}
>
{t.marketing.pricing.constants.yearly.toUpperCase()}
</ToggleGroupItem>
Expand Down