fix(api): require auth on /api/upload-auth#2
Open
abdout wants to merge 1 commit into
Open
Conversation
Mints ImageKit upload credentials only for authenticated sessions. Previously the endpoint was a public GET that returned token/expire/ signature/publicKey to anyone — letting attackers upload arbitrary content to our ImageKit account against our quota. Closes #1 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/upload-authwas an unauthenticatedGETreturning ImageKit upload credentials to anyone — a credential-leak vector against our ImageKit quota.auth()guard, returns401on no session, no other behavior change.src/components/ui/file-upload.tsx) already throws on non-OK responses, so the unauth path surfaces as a UI error rather than a crash.Changes
src/app/api/upload-auth/route.ts— importauthfrom@/auth, return 401 when no sessionTest plan
Closes #1
🤖 Generated with Claude Code