Improvments to tests and code #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is set to improve the stability as opendns [doesnt support json queries][odnsjson] and fails to provide the correct result and quad9.net has been inconsistent in results, causing occasional false results. [odnsjson]: https://support.opendns.com/hc/en-us/articles/360038463251-Querying-OpenDNS-using-DoH-for-developers-
RangerMauve
approved these changes
Mar 24, 2021
|
LGTM, invited @martinheidegger to the org so they can merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to work on #27 I looked through the code and found a few things that may improve this repository slightly making it easier for tests to pass.
This PR combines a few commits that mostly could be sent independently but reviewing would be a bit stressful. If you wish I could split up the commits into separate PR's.
Each commit message contains further information on the concrete change.