Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configurable liveness probe timeout #918

Merged
merged 4 commits into from
Nov 5, 2024
Merged

feat: Add configurable liveness probe timeout #918

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d38e185
feat: Add configurable liveness probe timeout
bnaul Oct 31, 2024
974d1ab
Update dask_kubernetes/operator/deployment/helm/dask-kubernetes-opera…
bnaul Nov 5, 2024
586e9db
Add livenessProbe timeout to README
bnaul Nov 2, 2024
a30c408
Fix README typo
bnaul Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dask_kubernetes/operator/deployment/helm/dask-kubernetes-operator/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ spec:
httpGet:
path: /healthz
port: 8080
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
volumeMounts:
{{- toYaml .Values.volumeMounts | nindent 12 }}
volumes:
Expand Down
3 changes: 3 additions & 0 deletions dask_kubernetes/operator/deployment/helm/dask-kubernetes-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ affinity: {} # Affinity

priorityClassName: null # Priority class

livenessProbe:
timeoutSeconds: 1
Copy link
Contributor Author

@bnaul bnaul Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobtomlinson I would probably say bump the default but no strong preference, figured I'd start with the same value and just make it configurable

Suggested change
timeoutSeconds: 1
timeoutSeconds: 5

bnaul marked this conversation as resolved.
Show resolved Hide resolved

kopfArgs: # Command line flags to pass to kopf on start up
- --all-namespaces

Expand Down
Loading