Skip to content

chore(release)!: prepare dev branch and Platform release workflow - #1552

Merged
lklimek merged 11 commits into
v1.8-devfrom
chore/dev-release-workflow
Nov 5, 2026
Merged

lklimek merged 11 commits into
v1.8-devfrom
chore/dev-release-workflow

Conversation

@lklimek

@lklimek lklimek commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR: Document how to contribute and release Tenderdash for Dash Platform, with a reviewed release process and preparation for one integration branch.

User story

As a Dash Platform maintainer, I want release versions and support expectations to reflect the changes being shipped and the networks using them.

As a contributor, I want current development, validation and review instructions so that I can prepare a change for integration.

Scenario

Base flow

Maintainers prepare a Tenderdash update for Dash Platform and decide how to release it safely.

Actual behavior

Documentation promises independent support across release lines, and release automation infers versions from branch names and commit labels. Development checks depend on versioned branch names. Contributor guidance includes obsolete build, testing and review instructions.

Expected behavior

Support follows Dash Platform needs. A project release skill reviews the actual changes and compatibility before selecting a version, while development checks support the planned dev branch. Contributors receive a practical guide grounded in observed development and release history.

Detailed discussion

What was done

  • Reposition README and security/contribution/release guidance around Dash Platform, with dev for integration and master for released code.
  • Rewrite CONTRIBUTING.md end to end: explain the Gitflow adaptation from observed integration, release-promotion, hotfix and forward-merge behavior; cover current build/BLS, focused checks, generated files, docs, dependencies, stacked PRs and the live PR Hygiene process. Separate the selected candidate SHA from the final reviewed release commit and document dev as integration and master as stable.
  • Align the related AGENTS.md review-trigger instruction with the supported claudius-review label.
  • Remove temporary integration-branch guidance from README, CONTRIBUTING, AGENTS, RELEASES and the project release skill; documentation and examples use dev.
  • Share one canonical .agents/skills/tenderdash-release/SKILL.md between Codex and Claude Code through the .claude/skills/tenderdash-release directory symlink; Claude Code invokes /tenderdash-release.
  • Add .agents/skills/tenderdash-release with actual history/net-diff SemVer review, stable hotfix isolation, reachable published baselines, frozen candidate SHAs, independent protocol versions, and coordinated Platform rollout.
  • Replace branch-inferred release automation and stale GoReleaser configuration with read-only evidence collection and an explicit local signed-artifact builder. Preserve Linux amd64/arm64 binary signatures and archives; add checksums and source provenance. The existing Docker publication workflow remains in place.
  • Prepare CI and local lint-base selection for dev. Repurpose release CI to test the helpers without publication permissions.
  • Remove the unused Mergify configuration and its merge-queue wording from the contributor guide; authorized maintainers merge under repository protections.

This is preparatory: no branch rename, protection change, release, or tag mutation. Maintainers must reconcile master's linear-history rule with the planned full-release promotion before release publication. Rename and default-branch changes remain separate operational steps.

Testing

Twelve isolated release scenarios and local-gate scenarios pass, including misleading commit labels, reverted changes, equivalent backports, hotfix isolation, frozen candidates after development advances, and signed-artifact orchestration. Independent synthetic forward-testing confirmed the frozen SHA excludes newer unreviewed changes and retains lineage guards without mutations.

Ruff checks/formatting, ShellCheck, shell syntax, project-skill validation, workflow syntax, and whitespace checks pass. Full actionlint reports only the existing check-generated.yml SC2155 issue, reproduced on the base. Markdown lint passes for the rewritten CONTRIBUTING.md; pre-existing AGENTS list indentation remains. No Go runtime files changed. Real Docker builds, signing keys, and external publication were not exercised; artifact orchestration uses isolated mocks.

The contributor guide was checked against a 90-day first-parent history and 12 representative merged PRs, including ancestry/patch checks for squash merges and release/hotfix propagation. Independent fact-checking, Markdown lint, 39 local path/fragment checks across the updated guides and Makefile command dry-runs pass. Runtime tests were not repeated for the documentation-only rewrite.

A read-only Mergify audit found no eligible open PRs, no Mergify merger among the latest 30 merged PRs, and no Mergify check/status activity on six representative PR heads. Repository reference scanning, contributor-guide Markdown lint and whitespace checks pass after removal.

Breaking changes

The old scripts/release/release.sh CLI and GoReleaser publication entry point are removed. Maintainers must use the project release skill and its explicit helpers. This changes the maintainer workflow; no Go, wire, or runtime configuration contract changes in this PR.

Attribution

Release archives include the root license and applicable root/database attribution files from the exact reviewed source revision. Component notices remain optional until the local database package is present. Twelve isolated release tests pass, including byte-for-byte archive notice checks for both architectures and exclusion of unreviewed working-copy edits; scoped Python, shell, and Markdown checks also pass. Docker/GPG execution remains mocked in these tests.

🤖 Co-authored by Claudius the Magnificent AI Agent

PR Hygiene · f7ff476

  • Bots — thepastaclaw skipped by lklimek
  • Self-review — posted; again after any push
  • Build green
  • Approvals — you own every area touched; none needed

When every merge requirement is met, the PR Hygiene check passes. Reviewer limits do not block merging; other required GitHub checks and protections still apply.

Scope support to Dash Platform and replace branch-inferred releases with a
project skill reviewing actual compatibility changes. Preserve signed artifact
preparation with exact-source helpers and prepare CI/local gates for dev.

BREAKING CHANGE: release.sh and GoReleaser publication are replaced by the
project release skill and explicit local release helpers.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

thepastaclaw commented Oct 20, 2026 •

Copy link
Copy Markdown

⛔ Final review complete — 1 blocking finding(s) (commit f7ff476)

lklimek and others added 10 commits October 20, 2026 14:17
Alias Claude Code discovery to the canonical project SKILL.md and document
its slash-command invocation alongside Codex discovery.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
Package the root license and available attribution/component notices from
the exact reviewed source. Keep existing binary paths and verify archive
contents both before and after the local database package is present.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
Preserve the Platform-scoped README and local release-tooling workflow
while incorporating Go 1.27.3 and the upstream GitHub app-token update.
Keep the dev and transitional CI branch filters intact.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Claude GPT-6 <noreply@anthropic.com>
Preserve the Platform release policy and dev branch preparation while
retaining current mdBook/spec navigation, documentation targets and Buf setup.
README conflict resolution approved by the maintainer.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Describe the Gitflow-style Platform workflow from verified release and
PR history, including current branch targets, stacked PRs and stable fixes.
Replace obsolete setup and review instructions with source-backed checks,
live PR Hygiene guidance and a clear final release commit boundary.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Document the supported label trigger used by the current review workflow.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Retain release-tooling verification and use the Ubuntu 26.04 runner
selected by the current base. Conflict resolution approved by the maintainer.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Remove the temporary v1.8-dev instructions from contributor and release documentation and use dev in examples.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
Drop dormant rules for the legacy release branch and document maintainer-controlled merging. Recent PR merge actors and check/status activity show no Mergify usage.

<sub>🤖 Co-authored by [Claudius the Magnificent](https://github.com/lklimek/claudius) AI Agent</sub>

Co-Authored-By: Codex GPT-6 <noreply@openai.com>
@lklimek
lklimek marked this pull request as ready for review November 4, 2026 18:01
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Nov 4, 2026

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

The release helpers and CI migration are consistent with the planned single integration branch, but the contributor guide now requires origin/dev before that remote branch exists, breaking its fresh-checkout and lint instructions. Static verification found one actionable documentation blocker; current CI reports successful release-tooling, build, test, E2E, lint, and generated-code checks, with only PR Hygiene pending. No local builds or tests were run.

🔴 1 blocking

Review provenance

Source: reviewer 1: muse-spark-1.3-contributor (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: normal by gpt-6.1-sol (effort low) — The cross-cutting release tooling, artifact-building scripts, tests, and CI changes alter behavior beyond documentation but do not directly change a qualifying critical surface.
  • Phase 1 reviewers: muse-spark-1.3-contributor — general (completed, effort xhigh); agent phase1-reviewer
  • Phase 1 model: muse-spark-1.3-contributor — not quota-gated; passed over gemini-3.8-flash-high (antigravity quota lookup failed), glm-5.3-flash (not used above high effort; tier asks max)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort high); agent phase2-reviewer
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `CONTRIBUTING.md`:
- [BLOCKING] CONTRIBUTING.md:60-65: Checkout instruction targets non-existent origin/dev
  The fresh-checkout procedure fails at `git switch -c my-change origin/dev`: a live `git ls-remote --heads origin dev v1.8-dev v1.9-dev` returns the two versioned branches but no `dev`. The example at line 92 also explicitly passes `LINT_BASE=origin/dev`, bypassing the Makefile's working migration fallback. This PR introduces these instructions while explicitly leaving the branch rename to a separate operational step, so contributors cannot follow the guide when it lands. Document `origin/v1.8-dev` as the current integration ref until the rename, or show branch selection that prefers `origin/dev` and falls back to `origin/v1.8-dev`; keep the planned final branch model clearly distinguished from commands that work today.

Comment thread CONTRIBUTING.md Resolved
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Your move: thepastaclaw requested changes on this head; dismiss the review or push a fix.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed and removed waiting-bots Waiting for the review bots to report on this head labels Nov 4, 2026
@lklimek
lklimek dismissed thepastaclaw’s stale review November 5, 2026 08:37

PR describes state after switching to new repo layout. I'll rename the base branch just after merging this PR.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Waiting for bot review — thepastaclaw not yet. Wait for the missing reviews, or a writer can post /skip-bots to proceed without them; blocking findings still need addressing.
Full checklist in the description.

@github-actions github-actions Bot added waiting-bots Waiting for the review bots to report on this head and removed waiting-self-review Waiting for the author to post /self-reviewed labels Nov 5, 2026
@lklimek

lklimek commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

/skip-bots

@lklimek

lklimek commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

/self-reviewed

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Bots are done — your move: post /self-reviewed.
Full checklist in the description.

@github-actions github-actions Bot added waiting-self-review Waiting for the author to post /self-reviewed bot-review-skipped A required review bot did not report; it was skipped by the window or by a person. and removed waiting-bots Waiting for the review bots to report on this head labels Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

Policy satisfied — this can merge.
Full checklist in the description.

@github-actions github-actions Bot removed the waiting-self-review Waiting for the author to post /self-reviewed label Nov 5, 2026
@lklimek
lklimek merged commit 3d91684 into v1.8-dev Nov 5, 2026
34 checks passed
@lklimek
lklimek deleted the chore/dev-release-workflow branch November 5, 2026 10:05
QuantumExplorer added a commit that referenced this pull request Nov 5, 2026
…-consensus-ccf700

v1.8-dev was renamed to dev; this brings in the two commits since then
(#1552 dev branch and release workflow, #1567 replay with historical
quorum). No conflicts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-review-skipped A required review bot did not report; it was skipped by the window or by a person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants