fix(platform-wallet-storage): don't look for or count non-funds used addresses as unresolved

packages/rs-platform-wallet-storage/Cargo.toml

@@ -173,6 +173,11 @@ windows-native-keyring-store = { version = "=1.0.0", optional = true }
 platform-wallet = { path = "../rs-platform-wallet", features = ["test-utils"] }
 proptest = "1"
 assert_cmd = "2"
+# `sqlite_dashpay_sibling_payment.rs` encrypts the contact request a DashPay
+# external account is built from, and implements the contact-crypto provider
+# trait a payment-address reservation takes.
+platform-encryption = { path = "../rs-platform-encryption" }
+async-trait = "0.1"
 static_assertions = "1"
 filetime = "0.2"
 # Test-only: construct the `Zeroizing<[u8; 32]>` secret on an
@@ -199,8 +204,10 @@ serial_test = "3"
 # outside — `cfg(test)` alone would satisfy it from within the crate.
 platform-wallet-storage = { path = ".", default-features = false, features = ["sqlite", "cli", "secrets", "kv", "__test-helpers", "test-util"] }
 # The adapter is a tokio task; the durability test drives it and awaits its
-# join handle. Current-thread runtime only — nothing here needs threads.
-tokio = { version = "1", features = ["rt", "macros", "sync"] }
+# join handle. `sqlite_dashpay_sibling_payment.rs` shuts a whole
+# `PlatformWalletManager` down, whose OS-thread workers need a multi-thread
+# runtime.
+tokio = { version = "1", features = ["rt", "rt-multi-thread", "macros", "sync"] }
 # The adapter's cancellation handle — the test passes a never-fired token, but
 # the parameter is part of the public signature.
 tokio-util = { version = "0.7", default-features = false }

packages/rs-platform-wallet-storage/src/sqlite/load_ctx.rs

@@ -62,8 +62,11 @@ pub enum LoadSite {
     RehydrationGapLimit,
     /// Rehydration could not maintain an address pool's gap limit.
     RehydrationMaintainGapLimit,
-    /// A restored UTXO or used address names an account this wallet lacks.
-    /// Counted per address, though one record covers a whole account's.
+    /// A restored UTXO or used address names an owner that is not a funds
+    /// account of this wallet: a funds account it lacks, or a DashPay
+    /// contact, identity, provider-key, asset-lock or Platform payment
+    /// account. Counted per address, though one record covers a whole
+    /// account's.
     OrphanedUtxoOwner,
     /// A restored address did not resolve against its account's xpub.
     /// Counted per address, though one record covers a whole account's.
@@ -165,7 +168,7 @@ impl LoadSite {
             // describes an accepted-as-is degradation rather than a
             // tolerated inconsistency.
             Self::OrphanedUtxoOwner => {
-                "load degraded: routing addresses from an unavailable owner to the first funds account"
+                "load degraded: owners that aren't this wallet's funds accounts (one it lacks, or a non-funds kind); coins go to the funds account deriving them, else the DashPay contact account holding them, off-balance, else the first; contacts' are the only non-funds used addresses sought"
             }
             Self::UnresolvedUtxoAddress => {
                 "load degraded: deferring addresses that did not resolve against the account xpub"
@@ -678,7 +681,7 @@ mod tests {
             "ambiguous owner",
         );
         assert!(logs_contain(
-            "load degraded: routing addresses from an unavailable owner to the first funds account"
+            "load degraded: owners that aren't this wallet's funds accounts (one it lacks, or a non-funds kind); coins go to the funds account deriving them, else the DashPay contact account holding them, off-balance, else the first; contacts' are the only non-funds used addresses sought"
         ));
     }