Skip to content

test(drive-abci): activate protocol version 14 in the credit pool backfill strategy tests #5735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 2 commits into from
Nov 3, 2026
Merged

test(drive-abci): activate protocol version 14 in the credit pool backfill strategy tests #5735

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8808cae
test(drive-abci): activate protocol version 14 in the credit pool bac…
shumkov Nov 3, 2026
6a1d075
Merge branch 'v5.1-dev' into shumkov/v51-fix-backfill-test
shumkov Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions packages/rs-drive-abci/tests/strategy_tests/test_cases/credit_pool_backfill_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,14 @@ mod tests {
use tenderdash_abci::proto::FromMillis;
use tenderdash_abci::Application;

/// The protocol version these tests activate: 14, whose upgrade backfills the credit pool
/// nullifiers and installs the token history contract v2 the assertions describe. Pinned,
/// as from version 15 the upgrade stores the contract compiled, and the activation epoch is
/// charged about 8000 bytes for its growth instead of the 108 the assertions expect.
fn activation_target() -> &'static PlatformVersion {
PlatformVersion::get(14).expect("expected protocol version 14")
}

/// The proposal of `round` for the next height, at chain-locked `core_chain_locked_height`
fn proposal(
outcome: &ChainExecutionOutcome,
Expand All @@ -70,10 +78,10 @@ mod tests {
core_chain_locked_height,
core_chain_lock_update: None,
proposer_pro_tx_hash: proposer.to_byte_array().to_vec(),
proposed_app_version: PlatformVersion::latest().protocol_version as u64,
proposed_app_version: activation_target().protocol_version as u64,
version: Some(Consensus {
block: 0,
app: PlatformVersion::latest().protocol_version as u64,
app: activation_target().protocol_version as u64,
}),
quorum_hash: outcome
.current_quorum()
Expand Down Expand Up @@ -167,7 +175,7 @@ mod tests {
let pv = if version == 1 {
PlatformVersion::get(13).expect("PV13")
} else {
PlatformVersion::latest()
activation_target()
};
let stored = platform
.drive
Expand Down Expand Up @@ -236,7 +244,7 @@ mod tests {

async fn activation_lifecycle(historical_token_history: bool) {
let old = PlatformVersion::get(13).expect("PV13");
let latest = PlatformVersion::latest();
let target = activation_target();
let config = PlatformConfig {
block_spacing_ms: 1000,
validator_set: ValidatorSetConfig {
Expand All @@ -259,7 +267,7 @@ mod tests {
chain_lock_quorum_count: 24,
upgrading_info: Some(UpgradingInfo {
current_protocol_version: 13,
proposed_protocol_versions_with_weight: vec![(latest.protocol_version, 1)],
proposed_protocol_versions_with_weight: vec![(target.protocol_version, 1)],
upgrade_three_quarters_life: 0.0,
}),
..Default::default()
Expand Down Expand Up @@ -288,7 +296,7 @@ mod tests {
.await;
let state = outcome.abci_app.platform.state.load();
assert_eq!(state.current_protocol_version_in_consensus(), 13);
assert_eq!(state.next_epoch_protocol_version(), latest.protocol_version);
assert_eq!(state.next_epoch_protocol_version(), target.protocol_version);
assert_eq!(state.last_committed_block_epoch().index, 1);
drop(state);

Expand Down Expand Up @@ -450,7 +458,7 @@ mod tests {
.platform
.drive
.grove
.root_hash(None, &latest.drive.grove_version)
.root_hash(None, &target.drive.grove_version)
.unwrap()
.expect("unchanged committed root"),
committed_root
Expand All @@ -459,7 +467,7 @@ mod tests {
assert!(!abci_app
.platform
.drive
.has_nullifier(&rho, None, &mut vec![], latest)
.has_nullifier(&rho, None, &mut vec![], target)
.expect("uncommitted backfill"));
}
{
Expand All @@ -477,7 +485,7 @@ mod tests {
assert!(abci_app
.platform
.drive
.has_nullifier(&rho, transaction.as_ref(), &mut vec![], latest)
.has_nullifier(&rho, transaction.as_ref(), &mut vec![], target)
.expect("candidate union"));
}
}
Expand Down Expand Up @@ -538,7 +546,7 @@ mod tests {
assert!(abci_app
.platform
.drive
.has_nullifier(&rho, transaction.as_ref(), &mut vec![], latest)
.has_nullifier(&rho, transaction.as_ref(), &mut vec![], target)
.expect("retried candidate union"));
}
}
Expand All @@ -560,7 +568,7 @@ mod tests {
.platform
.drive
.grove
.root_hash(None, &latest.drive.grove_version)
.root_hash(None, &target.drive.grove_version)
.unwrap()
.expect("committed root after rejection"),
committed_root
Expand All @@ -576,7 +584,7 @@ mod tests {
.platform
.drive
.grove
.root_hash(None, &latest.drive.grove_version)
.root_hash(None, &target.drive.grove_version)
.value
.expect("no speculative commit"),
committed_root
Expand All @@ -589,7 +597,7 @@ mod tests {
assert_token_history(abci_app.platform, None, 2, historical_token_history);
assert_eq!(
state.current_protocol_version_in_consensus(),
latest.protocol_version
target.protocol_version
);
assert_eq!(
state.last_committed_block_app_hash().map(Vec::from),
Expand All @@ -600,7 +608,7 @@ mod tests {
assert!(abci_app
.platform
.drive
.has_nullifier(&rho, None, &mut vec![], latest)
.has_nullifier(&rho, None, &mut vec![], target)
.expect("committed backfill"));
}
observations.push(accepted_root);
Expand All @@ -617,16 +625,16 @@ mod tests {
.state
.load()
.current_protocol_version_in_consensus(),
latest.protocol_version
target.protocol_version
);
assert_eq!(
reopened.state.load().next_epoch_protocol_version(),
latest.protocol_version
target.protocol_version
);
for rho in [[1u8; 32], [3u8; 32]] {
assert!(reopened
.drive
.has_nullifier(&rho, None, &mut vec![], latest)
.has_nullifier(&rho, None, &mut vec![], target)
.expect("backfill survives restart"));
}
}
Expand Down
Loading