Skip to content

test(contract): expect only the first schema violation of a document at protocol version 15 #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shumkov merged 1 commit into from
Oct 28, 2026
Merged

test(contract): expect only the first schema violation of a document at protocol version 15 #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 39 additions & 15 deletions packages/dashpay-contract/test/unit/schema.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,11 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('format');
.equal('minLength');
expect(error.instancePath)
.to
.deep
Expand Down Expand Up @@ -163,7 +163,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
let error = expectJsonSchemaError(validationResult, 2, 0);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand All @@ -172,16 +172,24 @@ describe('Dashpay Contract', () => {
.to
.deep
.equal({ missingProperty: 'avatarUrl' });
});

it('should require the other avatar properties when present alone', async () => {
profileData = {
avatarUrl: 'https://github.com/dashpay/dash.jpg',
};

error = expectJsonSchemaError(validationResult, 2, 1);
const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('required');
expect(error.params)
.to
.deep
.equal({ missingProperty: 'avatarUrl' });
.equal({ missingProperty: 'avatarHash' });
});
});

Expand Down Expand Up @@ -235,7 +243,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand All @@ -254,7 +262,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
let error = expectJsonSchemaError(validationResult, 2, 0);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand All @@ -263,16 +271,24 @@ describe('Dashpay Contract', () => {
.to
.deep
.equal({ missingProperty: 'avatarHash' });
});

error = expectJsonSchemaError(validationResult, 2, 1);
it('should require the other avatar properties when present alone', async () => {
profileData = {
avatarHash: Buffer.alloc(32),
};

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('required');
expect(error.params)
.to
.deep
.equal({ missingProperty: 'avatarHash' });
.equal({ missingProperty: 'avatarUrl' });
});
});

Expand Down Expand Up @@ -326,7 +342,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand All @@ -345,7 +361,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
let error = expectJsonSchemaError(validationResult, 2, 0);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand All @@ -354,16 +370,24 @@ describe('Dashpay Contract', () => {
.to
.deep
.equal({ missingProperty: 'avatarFingerprint' });
});

error = expectJsonSchemaError(validationResult, 2, 1);
it('should require the other avatar properties when present alone', async () => {
profileData = {
avatarFingerprint: Buffer.alloc(8),
};

const document = dpp.document.create(contract, identityId, 'profile', profileData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('required');
expect(error.params)
.to
.deep
.equal({ missingProperty: 'avatarFingerprint' });
.equal({ missingProperty: 'avatarUrl' });
});
});

Expand Down Expand Up @@ -681,7 +705,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'contactRequest', contactRequestData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand Down Expand Up @@ -731,7 +755,7 @@ describe('Dashpay Contract', () => {

const document = dpp.document.create(contract, identityId, 'contactRequest', contactRequestData);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
Expand Down
16 changes: 8 additions & 8 deletions packages/dpns-contract/test/unit/dpnsContract.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ describe('DPNS Contract', () => {

const document = dpp.document.create(dataContract, identityId, 'domain', rawDomainDocument);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('pattern');
.equal('maxLength');
expect(error.instancePath)
.to
.equal('/label');
Expand Down Expand Up @@ -264,11 +264,11 @@ describe('DPNS Contract', () => {

const document = dpp.document.create(dataContract, identityId, 'domain', rawDomainDocument);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('pattern');
.equal('maxLength');
expect(error.instancePath)
.to
.equal('/normalizedLabel');
Expand All @@ -291,16 +291,16 @@ describe('DPNS Contract', () => {
.equal('normalizedParentDomainName');
});

it('should be less than 190 chars', async () => {
rawDomainDocument.normalizedParentDomainName = 'a'.repeat(191);
it('should be less than 63 chars', async () => {
rawDomainDocument.normalizedParentDomainName = 'a'.repeat(64);

const document = dpp.document.create(dataContract, identityId, 'domain', rawDomainDocument);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('pattern');
.equal('maxLength');
expect(error.instancePath)
.to
.equal('/normalizedParentDomainName');
Expand Down
15 changes: 12 additions & 3 deletions packages/withdrawals-contract/test/unit/withdrawalsContract.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,14 @@ describe('Withdrawals contract', () => {

const document = dpp.document.create(dataContract, identityId, 'withdrawal', rawWithdrawalDocument);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('type');
expect(error.instancePath)
.to
.equal('/pooling');
expect(error.params.type)
.to
.equal('integer');
Expand Down Expand Up @@ -289,11 +292,14 @@ describe('Withdrawals contract', () => {

const document = dpp.document.create(dataContract, identityId, 'withdrawal', rawWithdrawalDocument);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('type');
expect(error.instancePath)
.to
.equal('/outputScript');
expect(error.params.type)
.to
.equal('array');
Expand Down Expand Up @@ -351,11 +357,14 @@ describe('Withdrawals contract', () => {

const document = dpp.document.create(dataContract, identityId, 'withdrawal', rawWithdrawalDocument);
const validationResult = document.validate(dpp.protocolVersion);
const error = expectJsonSchemaError(validationResult, 2);
const error = expectJsonSchemaError(validationResult);

expect(error.keyword)
.to
.equal('type');
expect(error.instancePath)
.to
.equal('/status');
expect(error.params.type)
.to
.equal('integer');
Expand Down
Loading