Skip to content

ci: allow the dashdex scope in pull request titles - #1317

Merged
romchornyi merged 1 commit into
developfrom
ci/allow-dashdex-scope
Nov 5, 2026
Merged

romchornyi merged 1 commit into
developfrom
ci/allow-dashdex-scope

Conversation

@romchornyi

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Dash DEX (the swap flow) has no scope in the PR title check, so its pull requests fail "Validate PR title" or have to borrow ui / wallet. #1297 is the current example.

What was done?

Added dashdex to the allowed scopes in .github/workflows/semantic-pull-request.yml. The check runs on pull_request_target, so the new scope applies to open PRs once this is on develop.

#1311 changes the same file (it pins the action); the hunks do not overlap.

How Has This Been Tested?

Config-only change; this PR's own title uses no scope. After merge, re-running the title check on #1297 with a dashdex scope shows it.

Breaking Changes

None.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • ADR (ADR-0001): not needed: N1
  • Nothing in this PR (files, commit messages, branch name, description, comments, attachments, linked issues) holds customer data, unfixed vulnerability detail, secrets, or step-by-step attack detail against keys, PIN or encryption; such content is left out and handled privately with the maintainers (ADR-0001, rule 2)

🤖 Generated with Claude Code

Dash DEX (the swap flow) had no scope of its own, so its pull requests
had to borrow ui or wallet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 450c78ec-afc2-4207-838b-de4dd15f5089
Commits

Reviewing files that changed from the base of the PR and between 3201192 and 7f4ae41.

Files selected for processing: 1

  • .github/workflows/semantic-pull-request.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@thepastaclaw

thepastaclaw commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

✅ Final review complete — no blockers (commit 7f4ae41) · triage: low

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

At head 7f4ae41, the complete diff correctly adds lowercase dashdex to the existing PR-title scope allowlist without changing workflow execution or permissions. No actionable defects were confirmed; the description explicitly specifies testing #1297 with a lowercase dashdex scope, rather than promising its current DashDex title will pass unchanged. Current CI reports successful simulator tests, test-target membership validation, and PR-title validation; no local builds or tests were run in this static review.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — Adding one allowed scope is a small, contained CI validation behavior change whose correctness is easy to confirm.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 99% left, weekly 49% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer

@romchornyi
romchornyi merged commit 5ee0ef4 into develop Nov 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants