Skip to content

build: bump blst to v0.3.17 - #139

Open
knst wants to merge 1 commit into
dashpay:developfrom
knst:bump-blst-0.3.17
Open

knst wants to merge 1 commit into
dashpay:developfrom
knst:bump-blst-0.3.17

Conversation

@knst

@knst knst commented Oct 21, 2026 •

Copy link
Copy Markdown

The pin inherited from Chia (a8cd361, between v0.3.10 and v0.3.11) is moved to the latest blst release. Every blst symbol the library uses is still present in the v0.3.17 headers and the files src/CMakeLists.txt compiles (server.c, assembly.S, the win64 .asm set) are unchanged in name, so no source change is needed.

It improved performance noticeable:

Benchmark a8cd361 v0.3.17 Speedup
Signing 0.2589 ms 0.2427 ms 1.07x
Verification 0.7463 ms 0.6607 ms 1.13x
Batch verification preparation 0.3316 ms 0.2819 ms 1.18x
Public key validation 0.0393 ms 0.0341 ms 1.15x
Signature validation 0.0582 ms 0.0487 ms 1.20x
Aggregation 1.2 µs 1.0 µs 1.19x
Batch verification 0.2895 ms 0.2417 ms 1.20x
Serialize PrivateKey 9.8 ns 9.9 ns no change
Serialize G1Element 51.5 ns 47.6 ns 1.08x
Serialize G2Element 99.3 ns 92.7 ns 1.07x
SerializeToArray PrivateKey 5.6 ns 5.7 ns no change
SerializeToArray G1Element 47.3 ns 43.6 ns 1.09x
SerializeToArray G2Element 93.1 ns 86.0 ns 1.08x

Depends on #138 and #132 (both merged)

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9e89e878-3e9a-47f8-95f0-8dd239d63394

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@knst knst changed the title Bump blst 0.3.17 build: bump blst to v0.3.17 Oct 21, 2026
@knst
knst marked this pull request as draft October 21, 2026 17:27
@thepastaclaw

thepastaclaw commented Oct 21, 2026 •

Copy link
Copy Markdown

✅ Final review complete — no blockers (commit 0189e6f) · triage: low

The pin inherited from Chia (a8cd361, between v0.3.10 and v0.3.11) is moved to the latest blst release. Every blst symbol the library uses is still present in the v0.3.17 headers and the files src/CMakeLists.txt compiles (server.c, assembly.S, the win64 .asm set) are unchanged in name, so no source change is needed.
@knst
knst force-pushed the bump-blst-0.3.17 branch from aa372d1 to 0189e6f Compare November 2, 2026 18:03
@knst
knst marked this pull request as ready for review November 2, 2026 18:04

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final validation — Phase 1 + Phase 2

Static verification of 0189e6f confirms the sole change pins blst to upstream v0.3.17; the referenced APIs and compilation units remain available, and no concrete in-scope defect was identified. Exact-head CI passes Linux GCC/Clang builds, tests and Valgrind, ARM binding checks, and Python Linux/Windows builds and tests. The macOS GCC, Clang, Go, Rust, JavaScript and Python checks display failures, but all six jobs were cancelled without executing any steps, indicating infrastructure cancellation rather than a demonstrated code failure; macOS compatibility remains unvalidated, and no local builds, tests or benchmarks were run.

Review provenance

Source: reviewer 1: glm-5.3-flash (agent: phase1-reviewer, role: general); reviewer 2: gpt-6.1-sol (agent: phase2-reviewer, role: general); reviewer 3: gpt-6.1-sol (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6.1-sol (agent: sol-verifier, role: final-verifier)

  • Triage: low by gpt-6.1-sol (effort low) — The diff is a small, contained CMake dependency pin update rather than a large or intricate change to cryptographic implementation code.
  • Phase 1 reviewers: glm-5.3-flash — general (completed, effort high); agent phase1-reviewer
  • Phase 1 model: glm-5.3-flash — zai quota: 5h 96% left, weekly 98% left; passed over gemini-3.8-flash-high (antigravity quota lookup failed)
  • Fresh verifier: gpt-6.1-sol — final-verifier; agent sol-verifier
  • Phase 2 reviewers: gpt-6.1-sol — general (completed, effort medium); agent phase2-reviewer, gpt-6.1-sol — security-auditor (completed, effort medium); agent phase2-reviewer

@knst
knst requested review from PastaPastaPasta and kwvg November 3, 2026 06:57

@kwvg kwvg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0189e6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants