Skip to content

[objective_c] Automate generation of ffigen's built in ObjC types lists #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 3, 2025

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented May 29, 2025

The ffigen config is now the canonical list of all the built in bindings. Also, run the interface_lists_test inside the code generator. That way, the old loop up regenerating the bindings, running the tests, and fiddling with the various lists of built-ins is reduced to:

  1. Run the bindings generator
  2. If it fails, add more bindings to ffigen_objc.yaml
  3. Repeat until it succeeds

Fixes #1249

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
objective_c _Version

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/native_doc_dartifier/test/native_doc_dartifier_test.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented May 29, 2025

Coverage Status

coverage: 90.942%. first build
when pulling b92d615 on objc_built_in_gen
into 215277e on main.

@liamappelbe liamappelbe merged commit a98c8e2 into main Jun 3, 2025
22 of 23 checks passed
@liamappelbe liamappelbe deleted the objc_built_in_gen branch June 3, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate generation of lists of package:objective_c exports
3 participants