[infra] Prepare to add ffigen, objective_c, swift2objc, and swiftgen to the workspace #2330
Conversation
github-actions
bot
added
type-infra
PR Health
API leaks
|
| Package | Leaked API symbols |
|---|---|
| objective_c | _Version |
This check can be disabled by tagging the PR with skip-leaking-check.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/jni/lib/src/third_party/generated_bindings.dart |
| pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart |
| pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart |
| pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart |
| pkgs/native_doc_dartifier/test/native_doc_dartifier_test.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
liamappelbe
changed the title
liamappelbe
changed the title
liamappelbe
changed the title
There was a problem hiding this comment.
LGTM!
The main change here is updating the tests to not assume they're being run from a particular directory. There are various tests in ffigen, objective_c, and swift2objc that need to load files, so I just copied the util other native packages are using to determine the package directory.
👍
We should share this util at some point.
Yeah I stared doing some relative imports in the hooks packages, but that's not pretty either.
Can't actually add them to the workspace yet, since package:objective_c is a flutter plugin.
👍
| - name: Run VM tests and collect coverage | ||
| run: dart run coverage:test_with_coverage --scope-output=ffigen --scope-output=objective_c | ||
| run: dart pub global run coverage:test_with_coverage --scope-output=ffigen --scope-output=objective_c |
There was a problem hiding this comment.
Can the objective_c and ffigen workflows be merged into one? (Can be done in a separate PR.)
There was a problem hiding this comment.
Probably. I'll look into it
The main change here is updating the tests to not assume they're being run from a particular directory. There are various tests in ffigen, objective_c, and swift2objc that need to load files, so I just copied the util other native packages are using to determine the package directory. We should share this util at some point.
Can't actually add them to the workspace yet, since package:objective_c is a flutter plugin.