Skip to content

add a script to regenerate the gRPC library; commit generated gRPC libraries - #237

Merged
devoncarew merged 9 commits into
mainfrom
gen_grpc
May 28, 2025
Merged

devoncarew merged 9 commits into
mainfrom
gen_grpc

Conversation

@devoncarew

Copy link
Copy Markdown
Contributor
  • add a script to regenerate the gRPC library
  • commit generated gRPC libraries

Done as two commits for easier review (the 2nd commit will be large).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions Bot added the type-infra A repository infrastructure change or enhancement label May 22, 2025
@devoncarew
devoncarew requested a review from natebosch May 22, 2025 14:31
@devoncarew

Copy link
Copy Markdown
Contributor Author

@craiglabenz, if you want to review, that would be helpful. The 2nd commit is very large but all machine generated; the bulk of the hand-written code is in the first commit.

The goal here is to generate an initial version of a gRPC Firestore client, and then fix up the generator (package:protoc_plugin) enough so that the client is functional, esp. wrt the Firestore.listen.

Comment thread pkgs/googleapis_firestore_v1/lib/google/api/annotations.pb.dart
@devoncarew
devoncarew merged commit 9aa2cae into main May 28, 2025
@devoncarew
devoncarew deleted the gen_grpc branch May 28, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:googleapis_firestore_v1 type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants