-
Notifications
You must be signed in to change notification settings - Fork 47
Upgrade to icu2 #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to icu2 #968
Conversation
PR Health
Breaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
intl4x | Breaking | 0.11.3 | 0.11.3 | 0.12.0 Got "0.11.3" expected >= "0.12.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
.
Changelog Entry ❗
Package | Changed Files |
---|---|
package:intl4x | pkgs/intl4x/example_native/pubspec.yaml pkgs/intl4x/lib/src/bindings/AnyCalendarKind.g.dart pkgs/intl4x/lib/src/bindings/Bcp47ToIanaMapper.g.dart pkgs/intl4x/lib/src/bindings/Bidi.g.dart pkgs/intl4x/lib/src/bindings/BidiClass.g.dart pkgs/intl4x/lib/src/bindings/BidiDirection.g.dart pkgs/intl4x/lib/src/bindings/BidiInfo.g.dart pkgs/intl4x/lib/src/bindings/BidiMirroringGlyph.g.dart pkgs/intl4x/lib/src/bindings/BidiPairedBracketType.g.dart pkgs/intl4x/lib/src/bindings/BidiParagraph.g.dart pkgs/intl4x/lib/src/bindings/Calendar.g.dart pkgs/intl4x/lib/src/bindings/CalendarError.g.dart pkgs/intl4x/lib/src/bindings/CalendarKind.g.dart pkgs/intl4x/lib/src/bindings/CanonicalCombiningClass.g.dart pkgs/intl4x/lib/src/bindings/CanonicalCombiningClassMap.g.dart pkgs/intl4x/lib/src/bindings/CanonicalComposition.g.dart pkgs/intl4x/lib/src/bindings/CanonicalDecomposition.g.dart pkgs/intl4x/lib/src/bindings/CaseMapCloser.g.dart pkgs/intl4x/lib/src/bindings/CaseMapper.g.dart pkgs/intl4x/lib/src/bindings/CodePointMapData16.g.dart pkgs/intl4x/lib/src/bindings/CodePointMapData8.g.dart pkgs/intl4x/lib/src/bindings/CodePointRangeIterator.g.dart pkgs/intl4x/lib/src/bindings/CodePointRangeIteratorResult.g.dart pkgs/intl4x/lib/src/bindings/CodePointSetBuilder.g.dart pkgs/intl4x/lib/src/bindings/CodePointSetData.g.dart pkgs/intl4x/lib/src/bindings/Collator.g.dart pkgs/intl4x/lib/src/bindings/CollatorAlternateHandling.g.dart pkgs/intl4x/lib/src/bindings/CollatorBackwardSecondLevel.g.dart pkgs/intl4x/lib/src/bindings/CollatorCaseFirst.g.dart pkgs/intl4x/lib/src/bindings/CollatorCaseLevel.g.dart pkgs/intl4x/lib/src/bindings/CollatorMaxVariable.g.dart pkgs/intl4x/lib/src/bindings/CollatorNumeric.g.dart pkgs/intl4x/lib/src/bindings/CollatorNumericOrdering.g.dart pkgs/intl4x/lib/src/bindings/CollatorOptions.g.dart pkgs/intl4x/lib/src/bindings/CollatorResolvedOptions.g.dart pkgs/intl4x/lib/src/bindings/CollatorStrength.g.dart pkgs/intl4x/lib/src/bindings/ComposingNormalizer.g.dart pkgs/intl4x/lib/src/bindings/CustomTimeZone.g.dart pkgs/intl4x/lib/src/bindings/DataError.g.dart pkgs/intl4x/lib/src/bindings/DataProvider.g.dart pkgs/intl4x/lib/src/bindings/Date.g.dart pkgs/intl4x/lib/src/bindings/DateFormatter.g.dart pkgs/intl4x/lib/src/bindings/DateFormatterGregorian.g.dart pkgs/intl4x/lib/src/bindings/DateLength.g.dart pkgs/intl4x/lib/src/bindings/DateTime.g.dart pkgs/intl4x/lib/src/bindings/DateTimeAlignment.g.dart pkgs/intl4x/lib/src/bindings/DateTimeFormatter.g.dart pkgs/intl4x/lib/src/bindings/DateTimeFormatterGregorian.g.dart pkgs/intl4x/lib/src/bindings/DateTimeFormatterLoadError.g.dart pkgs/intl4x/lib/src/bindings/DateTimeLength.g.dart pkgs/intl4x/lib/src/bindings/DateTimeMismatchedCalendarError.g.dart pkgs/intl4x/lib/src/bindings/DateTimeWriteError.g.dart pkgs/intl4x/lib/src/bindings/Decimal.g.dart pkgs/intl4x/lib/src/bindings/DecimalFormatter.g.dart pkgs/intl4x/lib/src/bindings/DecimalGroupingStrategy.g.dart pkgs/intl4x/lib/src/bindings/DecimalLimitError.g.dart pkgs/intl4x/lib/src/bindings/DecimalParseError.g.dart pkgs/intl4x/lib/src/bindings/DecimalRoundingIncrement.g.dart pkgs/intl4x/lib/src/bindings/DecimalSign.g.dart pkgs/intl4x/lib/src/bindings/DecimalSignDisplay.g.dart pkgs/intl4x/lib/src/bindings/DecimalSignedRoundingMode.g.dart pkgs/intl4x/lib/src/bindings/Decomposed.g.dart pkgs/intl4x/lib/src/bindings/DecomposingNormalizer.g.dart pkgs/intl4x/lib/src/bindings/DisplayNamesFallback.g.dart pkgs/intl4x/lib/src/bindings/DisplayNamesOptions.g.dart pkgs/intl4x/lib/src/bindings/DisplayNamesStyle.g.dart pkgs/intl4x/lib/src/bindings/EastAsianWidth.g.dart pkgs/intl4x/lib/src/bindings/EmojiSetData.g.dart pkgs/intl4x/lib/src/bindings/Error.g.dart pkgs/intl4x/lib/src/bindings/ExemplarCharacters.g.dart pkgs/intl4x/lib/src/bindings/FixedDecimal.g.dart pkgs/intl4x/lib/src/bindings/FixedDecimalFormatter.g.dart pkgs/intl4x/lib/src/bindings/FixedDecimalGroupingStrategy.g.dart pkgs/intl4x/lib/src/bindings/FixedDecimalSignDisplay.g.dart pkgs/intl4x/lib/src/bindings/GeneralCategory.g.dart pkgs/intl4x/lib/src/bindings/GeneralCategoryGroup.g.dart pkgs/intl4x/lib/src/bindings/GeneralCategoryNameToGroupMapper.g.dart pkgs/intl4x/lib/src/bindings/GeneralCategoryNameToMaskMapper.g.dart pkgs/intl4x/lib/src/bindings/GraphemeClusterBreak.g.dart pkgs/intl4x/lib/src/bindings/GraphemeClusterBreakIteratorLatin1.g.dart pkgs/intl4x/lib/src/bindings/GraphemeClusterBreakIteratorUtf16.g.dart pkgs/intl4x/lib/src/bindings/GraphemeClusterBreakIteratorUtf8.g.dart pkgs/intl4x/lib/src/bindings/GraphemeClusterSegmenter.g.dart pkgs/intl4x/lib/src/bindings/GregorianDateFormatter.g.dart pkgs/intl4x/lib/src/bindings/GregorianDateTimeFormatter.g.dart pkgs/intl4x/lib/src/bindings/GregorianZonedDateTimeFormatter.g.dart pkgs/intl4x/lib/src/bindings/HangulSyllableType.g.dart pkgs/intl4x/lib/src/bindings/IanaParser.g.dart pkgs/intl4x/lib/src/bindings/IanaParserExtended.g.dart pkgs/intl4x/lib/src/bindings/IanaToBcp47Mapper.g.dart pkgs/intl4x/lib/src/bindings/IndicSyllabicCategory.g.dart pkgs/intl4x/lib/src/bindings/IsoDate.g.dart pkgs/intl4x/lib/src/bindings/IsoDateTime.g.dart pkgs/intl4x/lib/src/bindings/IsoTimeZoneFormat.g.dart pkgs/intl4x/lib/src/bindings/IsoTimeZoneMinuteDisplay.g.dart pkgs/intl4x/lib/src/bindings/IsoTimeZoneOptions.g.dart pkgs/intl4x/lib/src/bindings/IsoTimeZoneSecondDisplay.g.dart pkgs/intl4x/lib/src/bindings/IsoWeekOfYear.g.dart pkgs/intl4x/lib/src/bindings/JoiningType.g.dart pkgs/intl4x/lib/src/bindings/LanguageDisplay.g.dart pkgs/intl4x/lib/src/bindings/LeadingAdjustment.g.dart pkgs/intl4x/lib/src/bindings/LineBreak.g.dart pkgs/intl4x/lib/src/bindings/LineBreakIteratorLatin1.g.dart pkgs/intl4x/lib/src/bindings/LineBreakIteratorUtf16.g.dart pkgs/intl4x/lib/src/bindings/LineBreakIteratorUtf8.g.dart pkgs/intl4x/lib/src/bindings/LineBreakOptions.g.dart pkgs/intl4x/lib/src/bindings/LineBreakStrictness.g.dart pkgs/intl4x/lib/src/bindings/LineBreakWordOption.g.dart pkgs/intl4x/lib/src/bindings/LineSegmenter.g.dart pkgs/intl4x/lib/src/bindings/ListFormatter.g.dart pkgs/intl4x/lib/src/bindings/ListLength.g.dart pkgs/intl4x/lib/src/bindings/Locale.g.dart pkgs/intl4x/lib/src/bindings/LocaleCanonicalizer.g.dart pkgs/intl4x/lib/src/bindings/LocaleDirection.g.dart pkgs/intl4x/lib/src/bindings/LocaleDirectionality.g.dart pkgs/intl4x/lib/src/bindings/LocaleDisplayNamesFormatter.g.dart pkgs/intl4x/lib/src/bindings/LocaleExpander.g.dart pkgs/intl4x/lib/src/bindings/LocaleFallbackConfig.g.dart pkgs/intl4x/lib/src/bindings/LocaleFallbackIterator.g.dart pkgs/intl4x/lib/src/bindings/LocaleFallbackPriority.g.dart pkgs/intl4x/lib/src/bindings/LocaleFallbackSupplement.g.dart pkgs/intl4x/lib/src/bindings/LocaleFallbacker.g.dart pkgs/intl4x/lib/src/bindings/LocaleFallbackerWithConfig.g.dart pkgs/intl4x/lib/src/bindings/LocaleParseError.g.dart pkgs/intl4x/lib/src/bindings/Logger.g.dart pkgs/intl4x/lib/src/bindings/MeasureUnit.g.dart pkgs/intl4x/lib/src/bindings/MeasureUnitParser.g.dart pkgs/intl4x/lib/src/bindings/MetazoneCalculator.g.dart pkgs/intl4x/lib/src/bindings/PluralCategories.g.dart pkgs/intl4x/lib/src/bindings/PluralCategory.g.dart pkgs/intl4x/lib/src/bindings/PluralOperands.g.dart pkgs/intl4x/lib/src/bindings/PluralRules.g.dart pkgs/intl4x/lib/src/bindings/PropertyValueNameToEnumMapper.g.dart pkgs/intl4x/lib/src/bindings/RegionDisplayNames.g.dart pkgs/intl4x/lib/src/bindings/ReorderedIndexMap.g.dart pkgs/intl4x/lib/src/bindings/Rfc9557ParseError.g.dart pkgs/intl4x/lib/src/bindings/Script.g.dart pkgs/intl4x/lib/src/bindings/ScriptExtensionsSet.g.dart pkgs/intl4x/lib/src/bindings/ScriptWithExtensions.g.dart pkgs/intl4x/lib/src/bindings/ScriptWithExtensionsBorrowed.g.dart pkgs/intl4x/lib/src/bindings/SegmenterWordType.g.dart pkgs/intl4x/lib/src/bindings/SentenceBreak.g.dart pkgs/intl4x/lib/src/bindings/SentenceBreakIteratorLatin1.g.dart pkgs/intl4x/lib/src/bindings/SentenceBreakIteratorUtf16.g.dart pkgs/intl4x/lib/src/bindings/SentenceBreakIteratorUtf8.g.dart pkgs/intl4x/lib/src/bindings/SentenceSegmenter.g.dart pkgs/intl4x/lib/src/bindings/Time.g.dart pkgs/intl4x/lib/src/bindings/TimeFormatter.g.dart pkgs/intl4x/lib/src/bindings/TimeLength.g.dart pkgs/intl4x/lib/src/bindings/TimePrecision.g.dart pkgs/intl4x/lib/src/bindings/TimeZone.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneAndCanonical.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneAndCanonicalAndNormalized.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneAndCanonicalAndNormalizedIterator.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneAndCanonicalIterator.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneFormatter.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneIdMapper.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneIdMapperWithFastCanonicalization.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneInfo.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneInvalidOffsetError.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneIterator.g.dart pkgs/intl4x/lib/src/bindings/TimeZoneVariant.g.dart pkgs/intl4x/lib/src/bindings/TitlecaseMapper.g.dart pkgs/intl4x/lib/src/bindings/TitlecaseOptions.g.dart pkgs/intl4x/lib/src/bindings/TrailingCase.g.dart pkgs/intl4x/lib/src/bindings/TransformResult.g.dart pkgs/intl4x/lib/src/bindings/UnicodeSetData.g.dart pkgs/intl4x/lib/src/bindings/UnitsConverter.g.dart pkgs/intl4x/lib/src/bindings/UnitsConverterFactory.g.dart pkgs/intl4x/lib/src/bindings/UtcOffset.g.dart pkgs/intl4x/lib/src/bindings/VariantOffsets.g.dart pkgs/intl4x/lib/src/bindings/VariantOffsetsCalculator.g.dart pkgs/intl4x/lib/src/bindings/VerticalOrientation.g.dart pkgs/intl4x/lib/src/bindings/WeekCalculator.g.dart pkgs/intl4x/lib/src/bindings/WeekInformation.g.dart pkgs/intl4x/lib/src/bindings/WeekOf.g.dart pkgs/intl4x/lib/src/bindings/WeekRelativeUnit.g.dart pkgs/intl4x/lib/src/bindings/Weekday.g.dart pkgs/intl4x/lib/src/bindings/WeekdaySetIterator.g.dart pkgs/intl4x/lib/src/bindings/WeekendContainsDay.g.dart pkgs/intl4x/lib/src/bindings/WindowsParser.g.dart pkgs/intl4x/lib/src/bindings/WordBreak.g.dart pkgs/intl4x/lib/src/bindings/WordBreakIteratorLatin1.g.dart pkgs/intl4x/lib/src/bindings/WordBreakIteratorUtf16.g.dart pkgs/intl4x/lib/src/bindings/WordBreakIteratorUtf8.g.dart pkgs/intl4x/lib/src/bindings/WordSegmenter.g.dart pkgs/intl4x/lib/src/bindings/YearStyle.g.dart pkgs/intl4x/lib/src/bindings/ZonedDateFormatter.g.dart pkgs/intl4x/lib/src/bindings/ZonedDateFormatterGregorian.g.dart pkgs/intl4x/lib/src/bindings/ZonedDateTime.g.dart pkgs/intl4x/lib/src/bindings/ZonedDateTimeFormatter.g.dart pkgs/intl4x/lib/src/bindings/ZonedDateTimeFormatterGregorian.g.dart pkgs/intl4x/lib/src/bindings/ZonedIsoDateTime.g.dart pkgs/intl4x/lib/src/bindings/ZonedTimeFormatter.g.dart pkgs/intl4x/lib/src/bindings/lib.g.dart pkgs/intl4x/lib/src/collation/collation_4x.dart pkgs/intl4x/lib/src/data.dart pkgs/intl4x/lib/src/data_4x.dart pkgs/intl4x/lib/src/hook_helpers/build_libs.g.dart pkgs/intl4x/lib/src/hook_helpers/build_options.dart pkgs/intl4x/lib/src/hook_helpers/hashes.dart pkgs/intl4x/lib/src/locale/locale_4x.dart pkgs/intl4x/pubspec.yaml |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check
.
Coverage ⚠️
File | Coverage |
---|---|
pkgs/intl4x/hook/build.dart | 💔 Not covered |
pkgs/intl4x/hook/link.dart | 💔 Not covered |
pkgs/intl4x/lib/src/collation/collation_4x.dart | 💔 Not covered |
pkgs/intl4x/lib/src/data.dart | 💔 Not covered |
pkgs/intl4x/lib/src/data_4x.dart | 💔 Not covered |
pkgs/intl4x/lib/src/hook_helpers/build_options.dart | 💔 Not covered |
pkgs/intl4x/lib/src/hook_helpers/hashes.dart | 💔 Not covered |
pkgs/intl4x/lib/src/locale/locale_4x.dart | 💔 Not covered |
pkgs/intl4x/tool/regenerate_hashes.dart | 💔 Not covered |
pkgs/intl4x/tool/write_option_file.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbols |
---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
On hold for now, until ICU4X exposes
setUnicodeExtension
for easier option mapping to locales.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.