Fixes #3210. Don't expect promotion from FutureOr<void> to Future<void> or void#3211
Merged
eernstg merged 1 commit intodart-lang:masterfrom Jun 4, 2025
Merged
Fixes #3210. Don't expect promotion from FutureOr<void> to Future<void> or void#3211eernstg merged 1 commit intodart-lang:masterfrom
FutureOr<void> to Future<void> or void#3211eernstg merged 1 commit intodart-lang:masterfrom
Conversation
… `Future<void>` or `void`
eernstg
reviewed
Jun 2, 2025
Member
eernstg
left a comment
eernstg
left a comment
There was a problem hiding this comment.
I think the description in A03_t13 needs to be adjusted. I'd suggest that line 37 expects s to have type Never, and then we'll wait for input from @stereotype441.
copybara-service Bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 6, 2025
2025-06-06 sgrekhov22@gmail.com Fixes dart-lang/co19#3217. Ignore warning in string_length_t07.dart (dart-lang/co19#3218) 2025-06-06 sgrekhov22@gmail.com dart-lang/co19#3180. Add tests for JSAnyOperatorExtension. Part 1. (dart-lang/co19#3215) 2025-06-04 sgrekhov22@gmail.com Fixes dart-lang/co19#3210. Don't expect promotion from `FutureOr<void>` to `Future<void>` or `void` (dart-lang/co19#3211) 2025-06-03 sgrekhov22@gmail.com Fixes dart-lang/co19#3192. Add tests for constant expression `String?.length` (dart-lang/co19#3209) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: If4f523a44a7efb9ac97dde388c293b1bc8dd1e4f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433321 Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.