Skip to content

docs: add credits #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 31, 2025

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Jul 29, 2025

Status

READY FOR REVIEW

Description

Updates the README to reflect acknowledging the original creators.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Jul 29, 2025
@alestiago alestiago added the documentation Improvements or additions to documentation label Jul 29, 2025
@felangel felangel marked this pull request as draft July 29, 2025 13:43
@alestiago alestiago marked this pull request as ready for review July 31, 2025 11:44
@alestiago alestiago requested a review from wolfenrain as a code owner July 31, 2025 11:44
@alestiago alestiago force-pushed the alestiago/acknowledgment-note branch from 51b56ae to cae6852 Compare July 31, 2025 17:32
Co-authored-by: Felix Angelov <[email protected]>
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ 💙

@felangel felangel changed the title docs: include Acknowledgments section docs: add credits Jul 31, 2025
@alestiago
Copy link
Contributor Author

Merging it in based on the various iterations on the received feedback (on/off GitHub).

We can always update the CREDITS.md or README.md down the road for any necessary adjustments.

@alestiago alestiago merged commit 3f103a7 into dart-frog-dev:main Jul 31, 2025
3 checks passed
@alestiago alestiago deleted the alestiago/acknowledgment-note branch July 31, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants