-
Notifications
You must be signed in to change notification settings - Fork 164
docs: add credits #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alestiago
merged 9 commits into
dart-frog-dev:main
from
alestiago:alestiago/acknowledgment-note
Jul 31, 2025
Merged
docs: add credits #1755
alestiago
merged 9 commits into
dart-frog-dev:main
from
alestiago:alestiago/acknowledgment-note
Jul 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecoca
reviewed
Jul 30, 2025
felangel
reviewed
Jul 31, 2025
51b56ae
to
cae6852
Compare
felangel
reviewed
Jul 31, 2025
felangel
reviewed
Jul 31, 2025
felangel
reviewed
Jul 31, 2025
Co-authored-by: Felix Angelov <[email protected]>
felangel
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅ 💙
Merging it in based on the various iterations on the received feedback (on/off GitHub). We can always update the CREDITS.md or README.md down the road for any necessary adjustments. |
erickzanardo
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY FOR REVIEW
Description
Updates the README to reflect acknowledging the original creators.
Type of Change