-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component-no-value exception #38
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: KGOH <[email protected]>
|
||
(t/deftest component-no-value-exception-test | ||
(t/is (= {:type ::di/component-no-value | ||
:stack [`component-no-value `parent-2 ::di/implicit-root]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don’t need the stack here. You can identIfy an invalid component just by its key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While just a key is enough to identify the component, it may not be enough in a case when a component returns nil, but I didn't expect this component to be executed at all. In such case it may be obvious why the component returns nil, but it would be not clear at all why this component was used at all in a such configuration
Though, we can omit the stack and wait when we stumble upon a such case where a stack would be helpful to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be two issues. The first is a notification about invalid component.
The second is about adding extra info such a stack of components.
You can solve the second with the following pattern:
(try
(...)
(catch RuntimeException ex
(throw (ex-info "..." {:stack stack} ex))))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
@slaughtlaught ^^^
Implements #37