Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component-no-value exception #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KGOH
Copy link
Collaborator

@KGOH KGOH commented Dec 6, 2024

Implements #37

@KGOH KGOH requested a review from darkleaf December 6, 2024 14:56

(t/deftest component-no-value-exception-test
(t/is (= {:type ::di/component-no-value
:stack [`component-no-value `parent-2 ::di/implicit-root]}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don’t need the stack here. You can identIfy an invalid component just by its key

Copy link
Collaborator Author

@KGOH KGOH Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While just a key is enough to identify the component, it may not be enough in a case when a component returns nil, but I didn't expect this component to be executed at all. In such case it may be obvious why the component returns nil, but it would be not clear at all why this component was used at all in a such configuration

Though, we can omit the stack and wait when we stumble upon a such case where a stack would be helpful to see

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be two issues. The first is a notification about invalid component.
The second is about adding extra info such a stack of components.

You can solve the second with the following pattern:

(try
  (...)
  (catch RuntimeException ex
    (throw (ex-info "..." {:stack stack} ex))))

Copy link
Collaborator Author

@KGOH KGOH Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!
@slaughtlaught ^^^

@darkleaf darkleaf mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants