Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree-sitter grammar: support Dicts #5340

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Tree-sitter grammar: support Dicts #5340

merged 2 commits into from
Mar 28, 2024

Conversation

OceanOak
Copy link
Collaborator

@OceanOak OceanOak commented Mar 27, 2024 •
edited
Loading

Changelog:

Tree-sitter-darklang
- Update the tree-sitter grammar to support dictionaries

#5321

@OceanOak OceanOak force-pushed the grammar-updates-8 branch from faceeb0 to 23b7c9c Compare March 27, 2024 16:18
@OceanOak OceanOak force-pushed the grammar-updates-8 branch from 23b7c9c to aac27e4 Compare March 28, 2024 08:34
@OceanOak OceanOak changed the title wip: tree-sitter grammar: support Dicts Tree-sitter grammar: support Dicts Mar 28, 2024
@OceanOak OceanOak marked this pull request as ready for review March 28, 2024 09:10
StachuDotNet
StachuDotNet approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@StachuDotNet StachuDotNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted one nit-pick, but it can be handled in another PR

@StachuDotNet StachuDotNet merged commit b9990c9 into darklang:main Mar 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StachuDotNet StachuDotNet StachuDotNet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OceanOak @StachuDotNet