fix: collection filtering condition (#13)

darkbasic · Dec 5, 2023 · 6229c18 · 6229c18
1 parent 01c8a3b
commit 6229c18
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/yellow-wolves-invent.md b/.changeset/yellow-wolves-invent.md
@@ -0,0 +1,5 @@
+---
+"mikro-orm-find-dataloader": patch
+---
+
+fix: collection filtering condition
diff --git a/packages/find/src/findDataloader.ts b/packages/find/src/findDataloader.ts
@@ -490,7 +490,9 @@ export function getFindBatchLoadFn<Entity extends object>(
         } else {
           // Our current filter is an object
           if (entityValue instanceof Collection) {
-            entityValue.find((entity) => filterResult(entity, value));
+            if (!entityValue.getItems().some((entity) => filterResult(entity, value))) {
+              return false;
+            }
           } else if (!filterResult(entityValue as object, value)) {
             return false;
           }