Skip to content

chore: New task execution task id test #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented May 13, 2025

Description

test how taskExecutionTaskId can be used for idempotency

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga changed the title [WIP] chore: New task execution task id test chore: New task execution task id test May 13, 2025
@javier-aliaga javier-aliaga marked this pull request as ready for review May 13, 2025 16:06
@javier-aliaga javier-aliaga requested review from a team as code owners May 13, 2025 16:06
@javier-aliaga javier-aliaga force-pushed the ja-task-idempotency-keys branch 2 times, most recently from ae29385 to 45872ef Compare May 15, 2025 16:14
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature! Mostly lgtm - mind adding a section or note about this somewhere in the daprdocs/?

Something as simple as saying use the ctx.getTaskExecutionKey() for xyz reasons will suffice.

Also, please ensure the header is added to every file

@javier-aliaga javier-aliaga reopened this May 20, 2025
@javier-aliaga javier-aliaga force-pushed the ja-task-idempotency-keys branch from 9de2450 to 97f8e2f Compare May 20, 2025 10:50
test how taskExecutionTaskId can be used for idempotency

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga force-pushed the ja-task-idempotency-keys branch from 97f8e2f to 3434802 Compare May 20, 2025 11:00
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga force-pushed the ja-task-idempotency-keys branch from ec48fe4 to 90b11d6 Compare May 20, 2025 11:23
@javier-aliaga
Copy link
Contributor Author

Thanks for adding this feature! Mostly lgtm - mind adding a section or note about this somewhere in the daprdocs/?

Something as simple as saying use the ctx.getTaskExecutionKey() for xyz reasons will suffice.

Also, please ensure the header is added to every file

Done!

https://github.com/dapr/java-sdk/blob/ec48fe46bbadf1b44759c2a6167d8d5fb2afab88/daprdocs/content/en/java-sdk-docs/java-workflow/java-workflow-howto.md#advanced-features

Signed-off-by: Javier Aliaga <[email protected]>
@artur-ciocanu
Copy link
Contributor

@javier-aliaga would you have sometime to address the review comments so we could merge this one. Thank you!

Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javier-aliaga this looks great! 🙇

@artur-ciocanu
Copy link
Contributor

@cicoyle if this looks good, could please re-approve. Thank you.

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (d759c53) to head (34715a9).
Report is 154 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1352      +/-   ##
============================================
+ Coverage     76.91%   78.17%   +1.26%     
- Complexity     1592     1832     +240     
============================================
  Files           145      223      +78     
  Lines          4843     5664     +821     
  Branches        562      601      +39     
============================================
+ Hits           3725     4428     +703     
- Misses          821      916      +95     
- Partials        297      320      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants