-
Notifications
You must be signed in to change notification settings - Fork 217
chore: New task execution task id test #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ae29385
to
45872ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this feature! Mostly lgtm - mind adding a section or note about this somewhere in the daprdocs/
?
Something as simple as saying use the ctx.getTaskExecutionKey()
for xyz reasons will suffice.
Also, please ensure the header is added to every file
9de2450
to
97f8e2f
Compare
test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
97f8e2f
to
3434802
Compare
Signed-off-by: Javier Aliaga <[email protected]>
ec48fe4
to
90b11d6
Compare
Done! |
Signed-off-by: Javier Aliaga <[email protected]>
daprdocs/content/en/java-sdk-docs/java-workflow/java-workflow-howto.md
Outdated
Show resolved
Hide resolved
@javier-aliaga would you have sometime to address the review comments so we could merge this one. Thank you! |
Signed-off-by: artur-ciocanu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javier-aliaga this looks great! 🙇
@cicoyle if this looks good, could please re-approve. Thank you. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1352 +/- ##
============================================
+ Coverage 76.91% 78.17% +1.26%
- Complexity 1592 1832 +240
============================================
Files 145 223 +78
Lines 4843 5664 +821
Branches 562 601 +39
============================================
+ Hits 3725 4428 +703
- Misses 821 916 +95
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
test how taskExecutionTaskId can be used for idempotency
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: