Cleaup Test Dependencies

[siri-varma]

Description

• I think having all the versions defined in the parent pom is a good idea.
• Moved the versions for testcontainer-module and spring-boot-example to parent pom. Depending on the feedback from this PR will work on rest of the modules in later prs.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #940

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[artur-ciocanu]

@siri-varma it seems that there are so missing classes after your POM changes and there some NoSuchMethodError messages in logs.

[siri-varma]

@artur-ciocanu Yes. Still working on fixing this

[siri-varma]

@artur-ciocanu @salaboy @cicoyle This PR is ready to be reviewed. Thank you

[salaboy]

@artur-ciocanu do you have any comments about this? Because the Dapr SDK is split into two big things (modules and sdk-tests), I believe that it was ok to do dependency management separately, as dependencies needed in the sdk-tests are not needed in the SDK itself (like toxy proxy). But if we are moving towards a world where we have all the SDK tests as testcontainer tests, this makes sense.

[salaboy]

@siri-varma to be clear.. I am not against this.. I am just thinking a bit long term how this will work out.

[siri-varma]

@artur-ciocanu do you have any comments about this? Because the Dapr SDK is split into two big things (modules and sdk-tests), I believe that it was ok to do dependency management separately, as dependencies needed in the sdk-tests are not needed in the SDK itself (like toxy proxy). But if we are moving towards a world where we have all the SDK tests as testcontainer tests, this makes sense.

@salaboy quick comment, my intention of moving all of them to the base pom is so that we can have one single place to manage all the dependencies. However, this need not affect the SDK/testcontainer test choices is what I feel.

Let me know if I am missing something.

[artur-ciocanu]

@siri-varma the PR looks great, I have left some comments, could you please take a look.

Also could you please provide a high level overview what are you trying to achieve with dependency cleanup PRs. I see the value in extracting version properties, however I am not following why we have to move them from respective places to parent POM.

[siri-varma]

@artur-ciocanu

If I take grpc-testing example

https://github.com/search?q=repo%3Adapr%2Fjava-sdk%20%22grpc-testing%22&type=code
It is declared with the version property in multiple places. This just felt redundant.
If we could define all dependencies along with versions in one single place (and from my experience this generally happens in the parent pom) it will make it cleaner.

I may be seeing this through the lens of my experience, open to get @dapr-javasdk maintainer thoughts as well.

[siri-varma]

@artur-ciocanu/ @salaboy / @dapr/maintainers-java-sdk addressed all the comments. Thank you

[siri-varma]

@artur-ciocanu / @dapr-java-sdk-reviewer / @salaboy This PR is ready to be reviewed

[siri-varma]

@artur-ciocanu / @dapr-java-sdk-reviewer / @salaboy

Just a gentle reminder about this PR

[artur-ciocanu]

LGTM, thanks for all this effort! 🙇

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (d759c53) to head (708d05c).
Report is 154 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1332      +/-   ##
============================================
+ Coverage     76.91%   78.13%   +1.22%     
- Complexity     1592     1830     +238     
============================================
  Files           145      223      +78     
  Lines          4843     5663     +820     
  Branches        562      601      +39     
============================================
+ Hits           3725     4425     +700     
- Misses          821      917      +96     
- Partials        297      321      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.