Skip to content

Standardized dotnet version via Directory.Build.Props file #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: release-1.16
Choose a base branch
from

Conversation

m3nax
Copy link
Contributor

@m3nax m3nax commented May 22, 2025

Description

The version used for compilation some times was provided through the Directory.Build.props file others directly in the .csproj file. In order to simplify its management now all projects use the one in the Directory.Build.props files.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

WhitWaldo and others added 6 commits April 1, 2025 17:32
…it test to validate reported customer issue. (dapr#1497)

Signed-off-by: Whit Waldo <[email protected]>
* Tentative fix for deserializing error
* Added unit tests to prove out timer deserialization for all supported formats

Signed-off-by: Whit Waldo <[email protected]>
* Updating gRPC, Google.Protobuf and Microsoft.DurableTask.* packages
* Porting the changes from Dapr.Cryptography 1.16 back to 1.15

Signed-off-by: Whit Waldo <[email protected]>
… actor deserialization for now (dapr#1530)

Signed-off-by: Whit Waldo <[email protected]>
@m3nax m3nax marked this pull request as ready for review May 22, 2025 21:59
@m3nax m3nax requested review from a team as code owners May 22, 2025 21:59
@WhitWaldo
Copy link
Contributor

I believe this may already be in place following a significant PR I made a few months ago in the release-1.16 branch.

PRs to the master branch should be minimized as it only reflects what's currently out there. All feature work is being done against release-1.16.

@m3nax
Copy link
Contributor Author

m3nax commented May 22, 2025

So I close this pr and open another one in branch 1.16?

@WhitWaldo
Copy link
Contributor

Just click edit at the top and you can change the target branch

@m3nax m3nax changed the base branch from master to release-1.16 May 23, 2025 08:28
@m3nax m3nax marked this pull request as draft May 23, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants