Skip to content

WIP: Add gRPC keep alive #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: release-1.16
Choose a base branch
from

Conversation

jjcollinge
Copy link

@jjcollinge jjcollinge commented May 21, 2025

Signed-off-by: Jonathan Collinge [email protected]

Description

Adds support for setting gRPC keep alives.
Can be set via builder or via env vars to keep consistent with dapr/java-sdk#1382.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@WhitWaldo
Copy link
Contributor

Thank you for the contribution - there's a lot on the gRPC side that needs another pass to offload to the gRPC client instead of trying to handle it in the SDK and I look forward to seeing what you come up with here.

That said, could you please target the release-1.16 branch? Master is reserved for the current release (e.g. bug fixes) and this would not be part of that.

@jjcollinge jjcollinge force-pushed the jjcollinge/keep-alive branch from 0c4b970 to 58ad730 Compare May 22, 2025 11:05
Signed-off-by: Jonathan Collinge <[email protected]>
@jjcollinge jjcollinge force-pushed the jjcollinge/keep-alive branch from 58ad730 to cd79aa4 Compare May 22, 2025 11:06
@jjcollinge jjcollinge changed the base branch from master to release-1.16 May 22, 2025 11:06
@jjcollinge
Copy link
Author

jjcollinge commented May 22, 2025

Thank you for the contribution - there's a lot on the gRPC side that needs another pass to offload to the gRPC client instead of trying to handle it in the SDK and I look forward to seeing what you come up with here.

That said, could you please target the release-1.16 branch? Master is reserved for the current release (e.g. bug fixes) and this would not be part of that.

Thanks @WhitWaldo - I've rebased on release-1.16 and moved the configuration to the grpc client builders. It's been many years since I've written csharp and I'm not familiar with this SDK so will need your guidance to push me in the right direction please.

@WhitWaldo
Copy link
Contributor

That's quite all right. Let me know if you run into an issue and I'd be happy to help out. Also feel free to ping or DM me on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants