Migrate Dapr programmatic pubsub functionality into Dapr.Messaging package #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essaging. Signed-off-by: Whit Waldo <[email protected]>
…to a separate client - note that this is a BREAKING CHANGE in the sense that several types have been renamed. Added programmatic PubSub functionality from Dapr.Client into package. Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
Signed-off-by: Whit Waldo <[email protected]>
watfordsuzy
reviewed
May 5, 2025
Comment on lines
+52
to
+55
| options.Converters.Add(new Rfc3389JsonConverter()); | ||
| var serializedTime = JsonSerializer.Serialize(value.Time, options).Trim('"'); | ||
|
|
||
| writer.WriteString("time", serializedTime); |
There was a problem hiding this comment.
This seems problematic.
- Adding the converter in a serializer is suspect, better to be plumbed through from above if that's the case.
- Serializing the value then trimming it then writing it out as a string is an expensive set of string ops that could be avoided.
- The converter is now going to be used during serialization of
value.Dataand that may be unexpected downstream.
Probably better to just inline the RFC 3389 serialization here for this specific field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the programmatic pubsub capabilities into Dapr.Messaging. This doesn't remove anything from Dapr.Client and is only additive. However, I've made changes to the shape of the API to simplify it and use more of the modern .NET functionality, so it's not necessarily a 1:1 transition from Dapr.Client to this implementation, but it's very similar. I should write up some documentation discussing this migration...
This PR also introduces a breaking change to Dapr.Messaging. Because I'm adding programmatic and declarative PubSub functionality, I needed to change the name of
DaprPublishSubscribeClientto something less exclusive (especially as it supports only streaming subscription capabilities). As such, this has been renamed toDaprPubSubStreamingClientand its various associated types renamed as well. The v1.16 release should mark the last time we need to change this name.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1509
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: