Fix plasma activation #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! Let's hear @rkuklik's opinion. |
rkuklik
reviewed
Jan 2, 2025
|
Hi, sorry for the delay (on both this and my PR). I like it, a lot. For the past couple of months I have been using my own hand rolled solution, and switching to this worked like a charm. Apart from my comment and maybe fixing the lint warnings and failing test (I have no idea why it complains), I thing it is ready. |
For reference, the lint warnings are visible in https://github.com/danth/stylix/pull/708/files.
This should already be resolved by commit a4ed416. |
rkuklik
reviewed
Jan 2, 2025
rkuklik
approved these changes
Jan 2, 2025
rkuklik
approved these changes
Jan 2, 2025
5 tasks
|
Hey, @trueNAHO, can we merge this? |
trueNAHO
approved these changes
Jan 3, 2025
pinarruiz
pushed a commit
to pinarruiz/stylix
that referenced
this pull request
Jan 4, 2025
…anth#708) Replace the systemd unit with a more robust AutostartScript for theme application during Plasma startup, ensuring D-Bus and session availability without breaking Home Manager activation. Closes: danth#340 Closes: danth#350 Closes: danth#422 Link: danth#708 Co-authored-by: rkuklik <[email protected]> Tested-by: lordkekz <[email protected]> Tested-by: rkuklik <[email protected]> Reviewed-by: NAHO <[email protected]>
|
Successfully created backport PR for |
stylix-automation bot
pushed a commit
that referenced
this pull request
Jan 4, 2025
…708) Replace the systemd unit with a more robust AutostartScript for theme application during Plasma startup, ensuring D-Bus and session availability without breaking Home Manager activation. Closes: #340 Closes: #350 Closes: #422 Link: #708 Co-authored-by: rkuklik <[email protected]> Tested-by: lordkekz <[email protected]> Tested-by: rkuklik <[email protected]> Reviewed-by: NAHO <[email protected]> (cherry picked from commit e0a41d3)
trueNAHO
pushed a commit
that referenced
this pull request
Jan 4, 2025
…708) Replace the systemd unit with a more robust AutostartScript for theme application during Plasma startup, ensuring D-Bus and session availability without breaking Home Manager activation. Closes: #340 Closes: #350 Closes: #422 Link: #708 Co-authored-by: rkuklik <[email protected]> Tested-by: lordkekz <[email protected]> Tested-by: rkuklik <[email protected]> Reviewed-by: NAHO <[email protected]> (cherry picked from commit e0a41d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #422, #350 and #340
Based on: #547
KDE theming uses CLI tools which require D-Bus and Plasma session. Instead of breaking home-manager activation, this PR creates a KDE "AutostartScript" that applies the Global Theme during the startup of Plasma.
It's basically a desktop entry in the autostart directory which has a special tag X-KDE-AutostartScript that tells Plasma to start it early. The X-KDE-AutostartScript is probably not required, since I noticed that plasma-manager is doing something similar without it.
This PR has the same scope as #547 but is better because the AutostartScript will run no matter how home-manager is installed - be it as a NixOS module or standalone or some custom solution. The approach of #547 is flawed in that regard because the systemd user unit needs to depend on the plasma session, but that might be started by many different means.
I have tested it on NixOS 24.11 beta (with Plasma 6.2.3).
Note: The AutostartScript will not be run on every activation, even if it is changed. This means that if you run
home-manager switchwhen the Plasma session is already running, any changes to the Global Theme won't be automatically applied. You can run the script manually from system settings to apply it.If you want, I can also make the script run on activation (but tolerate failure to avoid breaking activation outside of a Plasma session).