Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add well-formed package.el header and footer #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DarwinAwardWinner
Copy link

This will allow ido-speed-hack to be included in melpa.

As suggested in melpa/melpa#1868

@milkypostman
Copy link

@danskarda PING!

@Wilfred
Copy link

Wilfred commented Apr 6, 2016

In an ideal world, these improvements would be upstreamed to Emacs core.

Anywyay, as far as I can see, the ido.el only has changes to ido-read-internal (setting ido-cache-cur-list and ido-cache-cur-list-reverse) and ido-set-matches. These could be simple advice, making ido-speed-hack.el self-contained.

@Wilfred
Copy link

Wilfred commented Apr 28, 2016

Playing with this some more, it's not sufficient to advice ido-read-internal and ido-set-matches. There's also two other commits: one, two which make a huge difference. Without these, I don't see a speedup.

(I'm testing on larger ido datasets, like C-h f, which has a ~3 second delay without ido-speed-hack.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants