Repository navigation
Conversation
Allow the lockfile to use OAuthLib 4.0.1 by moving the socialaccount extra to django-allauth 65.22.1.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76a55af6cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [[package]] | ||
| name = "oauthlib" | ||
| version = "3.3.1" | ||
| version = "4.0.1" |
There was a problem hiding this comment.
Remove obsolete OAuthLib audit suppressions
With OAuthLib now locked at the fixed 4.0.1 release, the condition documented by the existing waivers is gone: scripts/audit_dependencies.sh:14-19 explicitly says to remove its two --ignore-vuln exceptions once allauth permits OAuthLib 4, while .trivyignore.yaml:6-15 still describes 3.3.1 as installed and fixed by 4.0.0. Leaving those entries means a later lockfile regression to the vulnerable release would remain invisible to pip-audit indefinitely (and to the container scan until the waiver expires), undermining the security purpose of this update; remove the stale suppressions with the version bump.
Useful? React with 👍 / 👎.
Summary
Upgrade
django-allauth[socialaccount]from65.15.0to65.22.1and lock OAuthLib at4.0.1. The previous allauth pin requires OAuthLib below4, so updating the lock alone cannot pick up OAuthLib's published security fixes. The resolver changed only those two dependency versions.Screenshots
Platforms
AI Assistance
Codex with GPT-6 assisted with the dependency resolution, diff review, and local test runs. Validation used Floppy's locked Python environment and Django test runner with a fresh disposable database.
How It Was Tested
uv lock --check --offlinepassed.uv sync --locked --no-default-groups --group testsucceeded.FLOPPY_TEST_DB_TEMPLATE=0 scripts/test.sh integrations.tests.test_oauth_views integrations.tests.test_oauth_device_flow config.tests.test_login_required --parallel 1passed all 85 tests with a synthetic application secret.git diff --check.Public API & Documentation Handoff
Human Review & Quality Assurance
Database & Migration Safety (Only if modifying models)
Related Issues
OAuthLib release notes · django-allauth changelog