Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/diagram.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ on:
- main
jobs:
get_data:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: Checkout code
uses: actions/checkout@master
- name: Update diagram
uses: githubocto/repo-visualizer@main
with:
excluded_paths: "ignore,.github"
branch: diagram
branch: diagram
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
fail-fast: false
matrix:
# need to figure out how to use redis on macos github actions
# os: [ubuntu, macos]
os: [ubuntu]
# os: [ubuntu-24.04, macos-15]
os: [ubuntu-24.04]
# remove until I sort out CI issues for truffle
# truffleruby,
# truffleruby-head,
Expand All @@ -27,7 +27,7 @@ jobs:
# Rails 8 requires ruby 3.2+.
- gemfile: 'Gemfile.rails8.0'
ruby: '3.1'
runs-on: ${{ matrix.os }}-latest
runs-on: ${{ matrix.os }}
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
services:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
bundle install --jobs 4
bundle exec rake test:solid_cache
starndardrb:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v7
- uses: ruby/setup-ruby@v1
Expand All @@ -84,7 +84,7 @@ jobs:
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- run: bundle exec standardrb --format github
javascript:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v7
- uses: actions/setup-node@v7
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# Coverband

[![GithubCI](https://github.com/danmayer/coverband/workflows/CI/badge.svg)](https://github.com/danmayer/coverband/actions)
[![Coverage Status](https://coveralls.io/repos/github/danmayer/coverband/badge.svg?branch=main)](https://coveralls.io/github/danmayer/coverband?branch=main)
[![Maintainability](https://api.codeclimate.com/v1/badges/1e6682f9540d75f26da7/maintainability)](https://codeclimate.com/github/danmayer/coverband/maintainability)
[![Discord Shield](https://img.shields.io/discord/609509533999562753)](https://discord.gg/KAH38EV)

Expand Down Expand Up @@ -137,7 +136,7 @@ run ActionController::Dispatcher.new
6. **Custom code against Coverband internals.** Only relevant if you wrote a tracker or call adapters directly:
- In a custom tracker, use `storage` instead of `redis_store`.
- Instead of `store.raw_store`, use `store.cleanup` (`clear_legacy!`, `clear_orphans!`), which returns `nil` for stores that cannot enumerate keys.
- `Coverband::Utils::Results#runtime_relavent_lines` is now spelled `runtime_relevant_lines`.
- Replace calls to the misspelled `Coverband::Utils::Results#runtime_relavent_lines` with `#runtime_relevant_lines`; the old spelling was removed in 7.0.
- `Coverband::Utils::SourceFile` and `Coverband::Utils::Result` take stored report records (`{"data" => [...]}`) rather than bare line arrays.

## Coverband Web UI
Expand Down
5 changes: 0 additions & 5 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,3 @@ desc "start webserver"
task :server do
exec "rackup -I lib"
end

desc "publish gem with 2 factor auth, reminder how"
task :publish_gem do
exec "gem push pkg/coverband-4.2.3.XXX.gem"
end
2 changes: 1 addition & 1 deletion changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* `Adapters::Base#size` now returns bytes as an Integer or `nil`; `size_in_mib` owns the "N/A" presentation. A store returning the string `"N/A"` previously reported `0.00` MiB.
* `Adapters::Base#get_coverage_report` now reports the receiver's coverage instead of routing through `Coverband.configuration.store`, which quietly returned another store's data when the receiver was not the configured one.
* Removed `AbstractTracker#redis_store`; custom trackers use `#storage`. Trackers no longer reach through the store to raw Redis commands.
* `Coverband::Utils::Results#runtime_relavent_lines` is renamed `#runtime_relevant_lines`.
* Removed the misspelled `Coverband::Utils::Results#runtime_relavent_lines`; use `#runtime_relevant_lines` instead.
* Removed `Adapters::Base#raw_store` and the Redis adapters' raw-client escape hatch. Redis maintenance now uses the narrow `store.cleanup` capability (`clear_legacy!` and `clear_orphans!`); adapters that cannot enumerate keys return `nil`.
* Work is retained when generation resolution fails, so a backend blip during a reporting cycle no longer discards that cycle's coverage. Previously only deltas that had reached the pending queue were protected, and the generation is resolved before the payload is enqueued. The retention caps apply to that held work too, so a sustained outage cannot grow the queue without limit
* A cache store that is not resolvable yet (`ActiveSupportCacheStore.new { Rails.cache }` running before Rails assigns `Rails.cache`) is no longer a `NoMethodError` on a nil target. It holds the cycle's work, logs, and resolves on a later cycle. A resolver returning something that is not a cache store now names the problem instead of failing deep in the storage layer
Expand Down
Loading