Merged
Conversation
wojciech-graj
force-pushed
the
bin-proto
branch
from
c24b345 to
23fa28f
Compare
Owner
|
Sorry, this one fell through the cracks. Would you mind reopening this PR? |
Contributor
Author
|
No worries, maintaining open-source software is thankless work, so take your time |
danlehmann
approved these changes
Feb 2, 2026
Owner
danlehmann
left a comment
danlehmann
left a comment
There was a problem hiding this comment.
I tried to come up with a more elegant BITS solution but couldn't make that work (on stable).
Excellent patch. Well tested and everything looks great to me. Thanks!
| // generic bit width. | ||
| macro_rules! impl_bin_proto { | ||
| ($type:tt, $trait:ident) => { | ||
| impl_bin_proto!($type, $trait, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128); |
Owner
There was a problem hiding this comment.
sigh...probably one of the poor decisions given that u8::BITS is u32
Could consider changing this for an arbitrary-int 3.0 release
Owner
|
Oh we forgot the changelog. I wrote up an entry here: #99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At work we're encoding/decoding types from arbitrary-int using the bin-proto crate. It would be useful to add support for this to arbitrary-int, so we don't have to maintain a fork.
But I also understand that this is additional maintenance burden (however small), so if that's an issue, we'll stick with the fork approach.