style: refactor static labels feat to be more compact#340
Open
DanArmor wants to merge 1 commit intodanihodovic:masterfrom
Open
style: refactor static labels feat to be more compact#340DanArmor wants to merge 1 commit intodanihodovic:masterfrom
DanArmor wants to merge 1 commit intodanihodovic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature that was introduced in #339 polutated a lot of code with
**self.static_labelin exporter.pySeparated static labels logic into child classes of prometheus metrics Gauge, Counter and Histogram and removed hardcoded
**self.static_labelfrom other parts of code to reduce chance of mistakes due to necessity to keep in mind this snippet when working with labels.