Remove rlib
crate-type so that it works with Miri
#4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
breaks compilation with miri (cc @RalfJung, maybe that should be mentioned in the README.md).
repro
Now, I cannot remember why I put that
"rlib"
thing to begin with, but after looking in more detail into what it does, I think it's doing do more harm than any potential good (or, at least, I should be using["rlib", "lib"]
to avoid removing"lib"
when with some compiler (such as miri's?) it isn't an alias for"rlib"
. And until somebody observes some breakage from replacing"rlib"
back with the default"lib"
, I will be favoring the default setting).