fix: persist compaction config from web UI#114
Conversation
StructuredConfigBody -> CoreConfig conversion was using default compaction config instead of the body's value, so enabling compaction from the web UI had no effect.
|
Warning Review limit reached
More reviews will be available in 23 minutes and 34 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Fix compaction config not being saved from the web UI.
Root cause
From<StructuredConfigBody> for CoreConfigusedCoreConfig::default().compaction.clone()instead ofb.compaction.into(), so the compaction section was always reset to defaults (disabled) on save.Fix
One line: use
b.compaction.into()to preserve the body's compaction settings.Test plan
cargo clippy --workspace -- -D warnings— clean