Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hideous but functional type generation using RobotOS.jl #2

Closed
wants to merge 1 commit into from
Closed

Hideous but functional type generation using RobotOS.jl #2

wants to merge 1 commit into from

Conversation

colinxs
Copy link

@colinxs colinxs commented Feb 17, 2019

This PR is a proof-of-concept for issue #1.

The primary purpose is to:

  1. Generate types that RobotOSData does not contain
  2. Generate types that are compatible with RobotOS

A few things:

  • Hideous and hacked implementation. Lot's of try/catches and eval(Meta.parse(...)) because I was lazy and needed a quick fix.
  • RobotOS.rostypegen() rebuilds the whole package, so if a new type is found in a package
    that was already built then a "WARNING replacing module ...." is generated.
  • For purpose (2) it would be nice if the type definitions in RobotOSData were compatible with RobotOS
    (e.x. publishing a RobotOSData.CommonMsgs.geometry_msgs.LaserScan in RobotOS). Towards that end, one option would be to scrap RobotOSData's msg definitions and add the ability for RobotOS's types to be written to a file (so that the types can be re-used on systems where ROS isn't available, which I believe was the motivation for RobotOSData's method of type generation).
  • We could use Requires.jl to make this optional based on whether the user already has RobotOS/PyCall etc.
  • This will fail Travis unless ROS is installed.

Thoughts?

@colinxs colinxs closed this by deleting the head repository Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant