Fix text mode #10
Merged
Fix text mode #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overhauls the way in which ksum reads input files to ensure that `--text` mode is properly respected. The major change is to change ksum from using `Ada.Text_IO.Text_Streams` to `Ada.Streams.Stream_IO` when reading files, as `Text_Streams` always reads in binary mode, whereas with `Stream_IO` we can force it into text mode using the `Interfaces.C_Streams` API. The implementation of the various file hashing algorithms has been changed to work on `Root_Stream_Type` rather than `File_Type`. This makes the code much more flexible and allows it to work with any (or mixed) stream implementations. The files have also been renamed to reflect their streaming nature (e.g. `file_hashing.ads` -> `stream_hashing.ads`). The implementation of the `Checksums` package has also been refactored into two child packages to decouple generation of checksums from verification.
This test verifies that CRLF are converted to LF on Windows platforms when `--text` mode is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls the way in which ksum reads input files to ensure that
--textmode is properly respected.The major change is to change ksum from using
Ada.Text_IO.Text_StreamstoAda.Streams.Stream_IOwhen reading files, asText_Streamsalways reads in binary mode, whereas withStream_IOwe can force it into text mode using theInterfaces.C_StreamsAPI.The implementation of the various file hashing algorithms has been changed to work on
Root_Stream_Typerather thanFile_Type. This makes the code much more flexible and allows it to work with any (or mixed) stream implementations. The files have also been renamed to reflect their streaming nature (e.g.file_hashing.ads->stream_hashing.ads).The implementation of the
Checksumspackage has also been refactored into two child packages to decouple generation of checksums from verification.A new test is also added to check that text translation works properly on Windows platforms.
This fixes #9