Add support for GetConfiguration messages in OCPP 1.6#90
Open
Dash wants to merge 2 commits intodallmann-consulting:mainfrom
Open
Add support for GetConfiguration messages in OCPP 1.6#90Dash wants to merge 2 commits intodallmann-consulting:mainfrom
Dash wants to merge 2 commits intodallmann-consulting:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for GetConfiguration messages. Unfortunately I only have a 1.6 charge point, so I've only added message support for this, but it shouldn't break where charge points are 2.0; instead the information won't be displayed. Obviously open for anyone else to add the relevant handlers in.
These messages bring back all the key/value pairs from the charge point which define the operation, which can be useful to know when troubleshooting. When navigating into a charge point through the admin user interface, it will send a GetConfiguration message to the charge point, which assuming the charge point responds, will be displayed.
This isn't entirely feature complete as there is paging support in OCPP to handle a limited number of values being returned in small batches. I'm not sure how much that's actually used in the real world (my charge point claims only to allow single values to be retrieved, but it then returns all of them).
The obvious next step would be to make the values display on an input form and allow the submission of new values.
I've tried to emulate the procedural coding style and approaches already taken for consistency.