Add validate method for polar file #24 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakk
reviewed
May 12, 2025
weatherrouting/polar.py
Outdated
|
|
||
|
|
||
| class PolarError(Exception): | ||
| def __init__(self, message): |
Owner
There was a problem hiding this comment.
This is not necessery; Exception already receives a list of arguments which are stored in Exception().args; you can put a "pass" in the body of the class
Owner
There was a problem hiding this comment.
class PolarError(Exception):
pass
is enough
Contributor
Author
There was a problem hiding this comment.
I am sorry, I missed it in my last commit.
Owner
There was a problem hiding this comment.
Still wrong:
class PolarError(Exception):
pass
dakk
requested changes
May 12, 2025
Closed
dakk
requested changes
May 14, 2025
weatherrouting/polar.py
Outdated
|
|
||
|
|
||
| class PolarError(Exception): | ||
| def __init__(self, message): |
Owner
There was a problem hiding this comment.
class PolarError(Exception):
pass
is enough
dakk
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.