feat: add GraphQL query for top post comments #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new query to return top N comments of a post ordered by number of upvotes. Supports optional first parameter (max 20).
rebelchris
approved these changes
Jan 6, 2026
src/schema/comments.ts
Outdated
|
|
||
| if (ctx.userId) { | ||
| builder.queryBuilder.andWhere( | ||
| whereNotUserBlocked(builder.queryBuilder, { |
Member
Author
There was a problem hiding this comment.
We don't need it, indeed
There was a problem hiding this comment.
Claude finished @idoshamun's task in 2m 5s —— View job
Completed
- Read the changed files to understand the context
- Identify what needs to be fixed based on review comments
- Remove unnecessary user blocking filter
- Commit and push changes
Summary
Removed the whereNotUserBlocked filter from the topComments query implementation (lines 1034-1040 in src/schema/comments.ts).
Rationale: For the SEO use case, crawlers are unauthenticated and won't have a ctx.userId, so this conditional filter wouldn't apply anyway. Removing it simplifies the code while maintaining the same behavior for SEO purposes.
The auto-lint hook should handle any formatting issues automatically.
Changes pushed
- Commit:
44400af- refactor: remove unnecessary user blocking filter from topComments query - Branch:
claude/add-top-comments-query-cxkqL
|
Allow querying topComments by either post ID or post slug, following the same pattern used in other post queries.
|
🍹 The Update (preview) for dailydotdev/api/prod (at 8be4c60) was successful. Resource Changes Name Type Operation
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-clickhouse-migration-f6ec76bb kubernetes:batch/v1:Job delete
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-8578223a kubernetes:batch/v1:Job create
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
+ vpc-native-api-clickhouse-migration-8578223a kubernetes:batch/v1:Job create
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-db-migration-f6ec76bb kubernetes:batch/v1:Job delete
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
|
The whereNotUserBlocked filter is not needed for the SEO use case since crawlers are unauthenticated and won't have a userId. Co-authored-by: Ido Shamun <[email protected]>
The slug column is a stored generated column that cannot be directly updated. Use the actual generated slug (p1-p1) instead of attempting to set a custom value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new query to return top N comments of a post ordered by number of upvotes. Supports optional first parameter (max 20).
This is required for some SEO changes