[Payload] A series of ECS-related fixes for Payload scenario #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daid
reviewed
Mar 17, 2025
| @@ -246,13 +242,13 @@ function ClearHazardsNear(centerX, centerY, radius, maxRoids, maxMines) | |||
|
|
|||
| -- Destroy any hazards beyond the limits | |||
| for _, potentialHazard in ipairs(objects) do | |||
| if potentialHazard.typeName == "Asteroid" then | |||
| if potentialHazard.components.explode_on_touch ~= nil then | |||
There was a problem hiding this comment.
Note that this can include missiles.
There was a problem hiding this comment.
Yeah, that's fine since this is just used to clear up mines and asteroids before the mission starts.
daid
reviewed
Mar 17, 2025
| @@ -658,7 +654,7 @@ function SpawnWave(faction) | |||
| if i == queenIndex and WaveSize > 1 then | |||
| enemyTemplate = "Phobos M3" | |||
| end | |||
| local enemy = CpuShip():setTemplate(enemyTemplate):setFaction("Kraylor"):setPosition(enemyX, enemyY) | |||
| local enemy = CpuShip():setTemplate(enemyTemplate):setFaction("Kraylor"):setPosition(enemyX, enemyY):orderIdle() | |||
There was a problem hiding this comment.
That idle isn't the default should be a bug.
There was a problem hiding this comment.
Noted. I'll see if I can implement a fix on the engine side, but this may also fix another edge case for me so might as well stay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.typeNamewith component checks